Moodle
  1. Moodle
  2. MDL-40100

MUC memcache store addinstanceform.php uses wrong lib.php

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.5
        • Fix Version/s: 2.4.5, 2.5.1
        • Component/s: Caching
        • Labels:
        • Testing Instructions:
          Hide
          1. Install Memcache and MongoDB if you don't already have them installed.
          2. Log in as an admin.
          3. Browse to Plugins > Caching > Configuration.
          4. Add a file store instance.
          5. Add a memcache store instance.
          6. Add a mongodb instance.
          7. Check you get no errors.
          Show
          Install Memcache and MongoDB if you don't already have them installed. Log in as an admin. Browse to Plugins > Caching > Configuration. Add a file store instance. Add a memcache store instance. Add a mongodb instance. Check you get no errors.
        • Affected Branches:
          MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          wip-MDL-40100-m26
        • Pull Master Diff URL:

          Description

          On line 30 of cache/stores/memcache/addinstanceform.php, cache/stores/memcached/lib.php is require_once'd and I believe that should be cache/stores/memcache/lib.php.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks for noting and reporting that Adam.

              In this case the include was entirely unnecessary, I've removed the include and having reviewed the other stores removed the includes from file and mongodb as well as they were unnecessary too.

              Up for integration review now.

              Many thanks
              Sam

              Show
              Sam Hemelryk added a comment - Thanks for noting and reporting that Adam. In this case the include was entirely unnecessary, I've removed the include and having reviewed the other stores removed the includes from file and mongodb as well as they were unnecessary too. Up for integration review now. Many thanks Sam
              Hide
              Permalink
              Dan Poltawski added a comment -

              Integrated to master, 25 and 24 - thnaks Sam!

              Show
              Dan Poltawski added a comment - Integrated to master, 25 and 24 - thnaks Sam!
              Hide
              Permalink
              Damyon Wiese added a comment -

              Tested on 24, 25 and master branches. No errors came up.

              Thanks!

              Show
              Damyon Wiese added a comment - Tested on 24, 25 and master branches. No errors came up. Thanks!
              Hide
              Permalink
              Marina Glancy added a comment -

              Thanks for your awesome work! This has now become a part of Moodle.

              Closing as fixed!

              Show
              Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: