Moodle

MUC memcache store addinstanceform.php uses wrong lib.php

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.4.5, 2.5.1
  • Component/s: Caching
  • Labels:

Description

On line 30 of cache/stores/memcache/addinstanceform.php, cache/stores/memcached/lib.php is require_once'd and I believe that should be cache/stores/memcache/lib.php.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for noting and reporting that Adam.

In this case the include was entirely unnecessary, I've removed the include and having reviewed the other stores removed the includes from file and mongodb as well as they were unnecessary too.

Up for integration review now.

Many thanks
Sam

Show
Sam Hemelryk added a comment - Thanks for noting and reporting that Adam. In this case the include was entirely unnecessary, I've removed the include and having reviewed the other stores removed the includes from file and mongodb as well as they were unnecessary too. Up for integration review now. Many thanks Sam
Hide
Permalink
Dan Poltawski added a comment -

Integrated to master, 25 and 24 - thnaks Sam!

Show
Dan Poltawski added a comment - Integrated to master, 25 and 24 - thnaks Sam!
Hide
Permalink
Damyon Wiese added a comment -

Tested on 24, 25 and master branches. No errors came up.

Thanks!

Show
Damyon Wiese added a comment - Tested on 24, 25 and master branches. No errors came up. Thanks!
Hide
Permalink
Marina Glancy added a comment -

Thanks for your awesome work! This has now become a part of Moodle.

Closing as fixed!

Show
Marina Glancy added a comment - Thanks for your awesome work! This has now become a part of Moodle. Closing as fixed!

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: