Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40119

No default submit action when clicking "Enter" in keyboard. Calendar pops up in assignment\forum setting page (maybe more places)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note, these instructions are largely a shameless ripoff of those in MDL-26649 which introduced this regression.

      This must be tested on all supported browsers.

      Enable JS

      1. Create a new quiz on your site.
      2. Whilst in the title area, hit the <return> key
        • Confirm that the page tried to save and the calendar did not open*
      3. On the editing page click to expand the 'Timing' section.
      4. Hover over the calendar icon next to 'Open the quiz' and 'Close the quiz' and ensure the image is not clickable and that the mouse icon does not change to a hand (this is the default behaviour (in Firefox anyway) when hovering over an input type image (even if it is disabled), this may confuse users who think they can interact with it even though the enable checkbox is not checked).
      5. Enable the 'Open the quiz' element by clicking on the 'Enable' checkbox.
      6. Click on the calendar icon and ensure the calendar pop-up displays and you can choose a date.
      7. Select a date and ensure the select box values populate with this date and the calendar closes.
      8. Click on the calendar icon again to display the pop-up and then click on it again to ensure it closes.
      9. Click on the calendar icon again to display the pop-up and then click anywhere else on the screen (besides the select boxes) to ensure it closes.
      10. Select a day, month and year using the select boxes, then click on the calendar icon and ensure the pop-up is set to this date.
      11. Change the date in the select boxes while the calendar pop-up is open and ensure the date changes.
      12. Uncheck the 'Enable' checkbox and repeat step 3.
      13. Create a new course.
      14. On the editing page for the 'Course start date' field repeat steps 3-11 as it is a dateselector element, not a datetimeselector.
      15. Create a new database activity and ensure you do not get the JS error 'TypeError: this.calendarimage is null' preventing the rest of JS on the form from loading.
      16. Try and break the calendar on Firefox with the firebug console open to spot any JS warnings/errors.

      Disable JS

      1. Create a new quiz on your site.
      2. On the editing page ensure there is no calendar icon next to the 'Open the quiz' and 'Close the quiz' fields.
      3. Create a new course.
      4. On the editing page ensure there is no calendar icon next to the 'Course start date' field.
      Show
      Note, these instructions are largely a shameless ripoff of those in MDL-26649 which introduced this regression. This must be tested on all supported browsers. Enable JS Create a new quiz on your site. Whilst in the title area, hit the <return> key Confirm that the page tried to save and the calendar did not open* On the editing page click to expand the 'Timing' section. Hover over the calendar icon next to 'Open the quiz' and 'Close the quiz' and ensure the image is not clickable and that the mouse icon does not change to a hand (this is the default behaviour (in Firefox anyway) when hovering over an input type image (even if it is disabled), this may confuse users who think they can interact with it even though the enable checkbox is not checked). Enable the 'Open the quiz' element by clicking on the 'Enable' checkbox. Click on the calendar icon and ensure the calendar pop-up displays and you can choose a date. Select a date and ensure the select box values populate with this date and the calendar closes. Click on the calendar icon again to display the pop-up and then click on it again to ensure it closes. Click on the calendar icon again to display the pop-up and then click anywhere else on the screen (besides the select boxes) to ensure it closes. Select a day, month and year using the select boxes, then click on the calendar icon and ensure the pop-up is set to this date. Change the date in the select boxes while the calendar pop-up is open and ensure the date changes. Uncheck the 'Enable' checkbox and repeat step 3. Create a new course. On the editing page for the 'Course start date' field repeat steps 3-11 as it is a dateselector element, not a datetimeselector. Create a new database activity and ensure you do not get the JS error 'TypeError: this.calendarimage is null' preventing the rest of JS on the form from loading. Try and break the calendar on Firefox with the firebug console open to spot any JS warnings/errors. Disable JS Create a new quiz on your site. On the editing page ensure there is no calendar icon next to the 'Open the quiz' and 'Close the quiz' fields. Create a new course. On the editing page ensure there is no calendar icon next to the 'Course start date' field.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-40119-master

      Description

      When clicking "Enter" in a setting form page (this has been tested in assignment\forum setting page,it might be functioning like this in other pages) there is no default submit action to save the page. instead the calendar pop-up pops up. this has been tested in standard theme. and in clean theme when clicking "Enter" there just no response.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                dobedobedoh Andrew Nicols
                Reporter:
                mikidream miki Alliel
                Peer reviewer:
                Petr Skoda
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Marina Glancy
                Participants:
                Component watchers:
                Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Jake Dallimore, Jun Pataleta, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              • Votes:
                2 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/14