Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40142

JS fatal error in navigation block

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as an admin.
      2. Use the navigation and expand the "Courses" branch to check AJAX expansion works.
      3. Turn on editing.
      4. Edit the navigation block and set "Generate navigation for the following" to "Categories, courses, and course structures"
      5. Save and browse back to the front page.
      6. Expand the courses branch in the navigation to ensure things load via AJAX.
      7. Browse to a course.
      8. Ensure you can expand any branch in the navigation still.
      9. Check that there have been no JS errors.
      Show
      Log in as an admin. Use the navigation and expand the "Courses" branch to check AJAX expansion works. Turn on editing. Edit the navigation block and set "Generate navigation for the following" to "Categories, courses, and course structures" Save and browse back to the front page. Expand the courses branch in the navigation to ensure things load via AJAX. Browse to a course. Ensure you can expand any branch in the navigation still. Check that there have been no JS errors.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-40142-m26

      Description

      As reported by John Porten in
      https://tracker.moodle.org/browse/MDL-39949?focusedCommentId=227916&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-227916

      We were able to reproduce the bug reported by Doug Moody.

      To recap: After upgrading to 2.5, the Activity Chooser link (+Add an activity or resource) was not working.

      What we found: A JS error occurs when the Navigation Block configuration option "Generate navigation for the following" is set to "Categories, courses, and course structures". The other options do not cause the error and the Activity Chooser link functions normally.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                samhemelryk Sam Hemelryk
                Reporter:
                marina Marina Glancy
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Marina Glancy
                Tester:
                Rajesh Taneja
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias, Andrew Nicols, Michael Hawkins, Bas Brands, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/13