Details

    • Testing Instructions:
      Hide
      • Run unit tests for backup/util/dbops/tests/*
        • Confirm that the correct number of tests and assertions were seen

      FYI, I see:

      OK (2 tests, 17 assertions)
      

      Show
      Run unit tests for backup/util/dbops/tests/* Confirm that the correct number of tests and assertions were seen FYI, I see: OK (2 tests, 17 assertions)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      Split out backup/util/dbops/tests into multiple files

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Hi Andrew,
              The name of files are incorrect. They must end in "_test.php" for our parser to be able to find it.(look phpunit.xml)

              Rest looks good.
              cheers.

              Show
              ankit_frenz Ankit Agarwal added a comment - Hi Andrew, The name of files are incorrect. They must end in "_test.php" for our parser to be able to find it.(look phpunit.xml) Rest looks good. cheers.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Cheers Ankit,

              I've corrected that schoolboy error. Submitting for integration now.

              Show
              dobedobedoh Andrew Nicols added a comment - Cheers Ankit, I've corrected that schoolboy error. Submitting for integration now.
              Hide
              marina Marina Glancy added a comment -

              Thanks Andrew, this has been integrated in 2.3, 2.4, 2.5 and master

              Show
              marina Marina Glancy added a comment - Thanks Andrew, this has been integrated in 2.3, 2.4, 2.5 and master
              Hide
              rwijaya Rossiani Wijaya added a comment -

              This is working as expected.

              Tested for 2.3, 2.4, 2.5 and master.

              Test passed.

              Show
              rwijaya Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4, 2.5 and master. Test passed.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for your contributions!

              _main:
              @ BB#0:
                      push    {r7, lr}
                      mov     r7, sp
                      sub     sp, #4
                      movw    r0, :lower16:(L_.str-(LPC0_0+4))
                      movt    r0, :upper16:(L_.str-(LPC0_0+4))
              LPC0_0:
                      add     r0, pc
                      bl      _printf
                      movs    r1, #0
                      movt    r1, #0
                      str     r0, [sp]                @ 4-byte Spill
                      mov     r0, r1
                      add     sp, #4
                      pop     {r7, pc}
               
                      .section        __TEXT,__cstring,cstring_literals
              L_.str:                                 @ @.str
                      .asciz   "This code is now upstream!"
              

              Show
              poltawski Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4-byte Spill mov r0, r1 add sp, #4 pop {r7, pc}   .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Jul/13