Moodle
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-40180

RTL/Clean theme: Misalignment of student name and profile image in grader

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as Admin and select Clean theme to test.
      2. Go to any course page and select Grades from Course administration block.
      3. Change to RTL language Hebrew (he) or Arabic (ar) and TEST that the profile image and student name is as depicted in the "Right" screenshot below.
      Show
      Login as Admin and select Clean theme to test. Go to any course page and select Grades from Course administration block. Change to RTL language Hebrew (he) or Arabic (ar) and TEST that the profile image and student name is as depicted in the "Right" screenshot below.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40180_master
    • Rank:
      50927

      Description

      This is the fix for this problem.

      .dir-rtl table#user-grades th.category,
      .dir-rtl table#user-grades th#studentheader,
      .dir-rtl table#user-grades th.user {
          text-align: right;
      }
      
      .path-grade-report-grader.dir-rtl th.user img.userpicture {
          margin-left: 0.5em;
      }
      

        Activity

        Hide
        Mary Evans added a comment -

        Just assigned this to you Nadav. Fix code is in description.

        Shalom
        Mary

        Show
        Mary Evans added a comment - Just assigned this to you Nadav. Fix code is in description. Shalom Mary
        Hide
        Nadav Kavalerchik added a comment -

        Your suggested changes fixes the current issue (tested locally)
        I have added those fixes to /theme/bootstrapbase/less/moodle/grade.less
        and recompiled /theme/bootstrapbase/less/moodle.less into /theme/bootstrapbase/style/moodle.less
        both, updated files, are in the committed fix. Please review

        Show
        Nadav Kavalerchik added a comment - Your suggested changes fixes the current issue (tested locally) I have added those fixes to /theme/bootstrapbase/less/moodle/grade.less and recompiled /theme/bootstrapbase/less/moodle.less into /theme/bootstrapbase/style/moodle.less both, updated files, are in the committed fix. Please review
        Hide
        Mary Evans added a comment -

        Looks OK so setting this for Integration Review

        Show
        Mary Evans added a comment - Looks OK so setting this for Integration Review
        Hide
        Dan Poltawski added a comment -

        Thanks Nadav and Mary, i've integrated this to 2.5 (cherry-picked) and master.

        Show
        Dan Poltawski added a comment - Thanks Nadav and Mary, i've integrated this to 2.5 (cherry-picked) and master.
        Hide
        Rossiani Wijaya added a comment -

        This works as expected.

        Tested for 2.5 and master.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This works as expected. Tested for 2.5 and master. Test passed.
        Hide
        Dan Poltawski added a comment -

        Thanks for your contributions!

        _main:
        @ BB#0:
                push    {r7, lr}
                mov     r7, sp
                sub     sp, #4
                movw    r0, :lower16:(L_.str-(LPC0_0+4))
                movt    r0, :upper16:(L_.str-(LPC0_0+4))
        LPC0_0:
                add     r0, pc
                bl      _printf
                movs    r1, #0
                movt    r1, #0
                str     r0, [sp]                @ 4-byte Spill
                mov     r0, r1
                add     sp, #4
                pop     {r7, pc}
        
                .section        __TEXT,__cstring,cstring_literals
        L_.str:                                 @ @.str
                .asciz   "This code is now upstream!"
        
        Show
        Dan Poltawski added a comment - Thanks for your contributions! _main: @ BB#0: push {r7, lr} mov r7, sp sub sp, #4 movw r0, :lower16:(L_.str-(LPC0_0+4)) movt r0, :upper16:(L_.str-(LPC0_0+4)) LPC0_0: add r0, pc bl _printf movs r1, #0 movt r1, #0 str r0, [sp] @ 4- byte Spill mov r0, r1 add sp, #4 pop {r7, pc} .section __TEXT,__cstring,cstring_literals L_.str: @ @.str .asciz "This code is now upstream!"

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: