Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.5, 2.6
-
Component/s: Themes
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-40213_master -
Pull Master Diff URL:
Description
I noticed a bug in the secure page layout for the clean theme. It is missing this code from the head:
// Get the HTML for the settings bits.
$html = theme_clean_get_html_for_settings($OUTPUT, $PAGE);
Without this - it should get an undefined variable warning later in the page when it writes the page header.
With developer level debugging on, the following errors are reported:
Notice: Undefined variable: html in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51
Notice: Trying to get property of non-object in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51
Attachments
Issue Links
- has been marked as being related by
-
MDL-31365 Safe Exam Browser window is not safe
-
- Closed
-