Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40213

Clean theme layout "secure.php" missing settings.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5, 2.6
    • Fix Version/s: 2.5.4, 2.6.1, 2.7, FRONTEND
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select the 'Clean' theme.
      2. Turn on developer level debugging.
      3. Create a course.
      4. Add a quiz and in 'Extra restrictions on attempts' -> 'Browser security' set to 'Full screen pop-up with some JavaScript security'. See http://docs.moodle.org/26/en/Quiz_settings#Extra_restrictions_on_attempts for more information.
      5. Add one question.
      6. Go to the quiz and click on the 'Attempt quiz now'.
      7. Observe that the error occurs and that the course name is not displayed at the top.
      8. Apply the patch.
      9. Refresh the page and observe that the error no longer occurs and the course name is displayed at the top.
      Show
      Select the 'Clean' theme. Turn on developer level debugging. Create a course. Add a quiz and in 'Extra restrictions on attempts' -> 'Browser security' set to 'Full screen pop-up with some JavaScript security'. See http://docs.moodle.org/26/en/Quiz_settings#Extra_restrictions_on_attempts for more information. Add one question. Go to the quiz and click on the 'Attempt quiz now'. Observe that the error occurs and that the course name is not displayed at the top. Apply the patch. Refresh the page and observe that the error no longer occurs and the course name is displayed at the top.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-40213_master

      Description

      I noticed a bug in the secure page layout for the clean theme. It is missing this code from the head:

      // Get the HTML for the settings bits.
      $html = theme_clean_get_html_for_settings($OUTPUT, $PAGE);

      Without this - it should get an undefined variable warning later in the page when it writes the page header.

      With developer level debugging on, the following errors are reported:

      Notice: Undefined variable: html in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51

      Notice: Trying to get property of non-object in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14