Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 2.5, 2.6
-
Component/s: Themes
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-40213_master -
Pull Master Diff URL:
Description
I noticed a bug in the secure page layout for the clean theme. It is missing this code from the head:
// Get the HTML for the settings bits.
$html = theme_clean_get_html_for_settings($OUTPUT, $PAGE);
Without this - it should get an undefined variable warning later in the page when it writes the page header.
With developer level debugging on, the following errors are reported:
Notice: Undefined variable: html in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51
Notice: Trying to get property of non-object in F:\moodledev\moodlegjb\theme\clean\layout\secure.php on line 51
Gliffy Diagrams
Attachments
Issue Links
- has been marked as being related by
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
I am not sure if that layout should have the settings as this is meant to be a secure page where test take place, usually using quizes. It's not so much a secure site but rather a secure browser that you need to download that stops student surfing when in a test situation. As far as I recall Sam added this layout to Bootstrapbase, so I suspect he left that off deliberately.
Anyway all that code does is allows the logo in the header. If this layout needs a header then add it in.
Best person to ask about the browser is Tim Hunt
I've assigned this to you Gareth
MDL-31365 for more info on the origin of the 'Secure' layout. 
If you check this out Gareth you will also find that the secure layout in bootstrapbase/config.php is missing vital options...
'options' => array('nofooter'=>true, 'nonavbar'=>true,
|
'nocustommenu'=>true, 'nologinlinks'=>true,
|
'nocourseheaderfooter'=>true),
|
Which to my way of thinking is more important!
The 'secure' layout is used by the quiz when you turn on the option Browser security: Pop-up window with some JavaScript. No special browsers required to test this.
In that case Gareth, going on how Afterburner treats this is to add the missing line of code back. Jobs a good un!
Hi Gareth,
Thank you for fixing this issue.
Patch look great.
This should be integrated to 2.5, 2.6 and master.
Submitting for integration review.
Thanks Gareth, integrated in 2.5, 2.6 and master.
I cherry-picked commit to 2.6 branch but can you please create a separate branch next time. Thanks again.
Thanks Marina Glancy, I thought M2.6 and master branches were linked after the release of M2.6 until M2.6.1 as was with M2.5 and master until M2.5.1. Must be mistaken and will do.
The on-sync period when 2.6 was kept [almost] exactly the same as 2.7 was only 2 weeks. And even during this period we integrate to 2.6 and master branches separately.
Test result: 
Success!
Tested in 2.5, 2.6 and master. Tested as admin and student.
No errors were shown in Integration version.
Thanks for your efforts.
Thanks for the code, its now upstream!
Heres a fun trick to try in the spirit of Friday the 13th.
I hear if you stand in front a mirror, alone, in the dark, and say "Oracle" three times Petr Skoka will appear in the mirror and you'll see him deleting the Oracle driver from Moodle.
Just bumped into this whilst looking at the layout files in M2.6 - I could do the fix but do not have a secure site upon which to test. Mary Evans thoughts?