Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40228

Incorrect backup setting names in automated backups

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.2, 2.6.3, 2.7
    • Fix Version/s: 2.6.4, 2.7.1
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      1. Set up a course with activity completion enabled
      2. With a user, set an activity of that course as completed
      3. Set up the automated backups
      4. Select all the "Automated backup settings"
      5. Run the CLI admin/cli/automated_backups.php
      6. Open the generated zip file and make sure that it contains the data that you'd expect.
        • For instance, the complexion.xml file contains completion data
        • Alternatively, restore it somewhere and make sure it contains everything
      7. Change the "Automated backup settings", especially "backup_auto_userscompletion" (untick it)
      8. Run the CLI again
      9. Open the generated ZIP file
        • The completion.xml file should not contain the user completion any more
        • Alternatively restore the backup and check that it does not restore the completion data
      Show
      Set up a course with activity completion enabled With a user, set an activity of that course as completed Set up the automated backups Select all the "Automated backup settings" Run the CLI admin/cli/automated_backups.php Open the generated zip file and make sure that it contains the data that you'd expect. For instance, the complexion.xml file contains completion data Alternatively, restore it somewhere and make sure it contains everything Change the "Automated backup settings", especially "backup_auto_userscompletion" (untick it) Run the CLI again Open the generated ZIP file The completion.xml file should not contain the user completion any more Alternatively restore the backup and check that it does not restore the completion data
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40228-master
    • Pull Master Diff URL:
    • Story Points:
      8
    • Sprint:
      FRONTEND Sprint 12

      Description

      Looks like launch_automated_backup::backup_cron_automated_helper has some incorrect setting names:

      • completion_information should be userscompletion
      • histories should be grade_histories

      This must be verified, but I copied this code for my own use and noticed that "$bc->get_plan()->setting_exists($setting)" failed for those two.

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            bushido Mark Nielsen
            Peer reviewer:
            David Monllaó
            Integrator:
            Dan Poltawski
            Tester:
            Andrew Davis
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Jul/14