Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.7, 2.4.4, 2.5, 2.6
    • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
    • Component/s: Unit tests
    • Labels:
    • Story Points (Obsolete):
      5
    • Sprint:
      BACKEND Sprint 3

      Description

      Add unit tests for core_files_external::upload()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Adrian Greeve added a comment -

            Thanks Ankit,

            This looks like it covers most of the code. Good luck with fixing the core function

            Show
            Adrian Greeve added a comment - Thanks Ankit, This looks like it covers most of the code. Good luck with fixing the core function
            Hide
            Ankit Agarwal added a comment -

            Thanks for the review Adrian.
            Submitting for integration.

            @integrators
            Master only please.
            Thanks

            Show
            Ankit Agarwal added a comment - Thanks for the review Adrian. Submitting for integration. @integrators Master only please. Thanks
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hi Ankit, is there any special reason for not picking this to all stable supported branches? We use to backport tests as much as possible and this seems simple and isolated enough to be spread backwards.

            So, unless there is another reason, I'm considering to backport this. Will keep it open for some hours, awaiting for feedback.

            Show
            Eloy Lafuente (stronk7) added a comment - Hi Ankit, is there any special reason for not picking this to all stable supported branches? We use to backport tests as much as possible and this seems simple and isolated enough to be spread backwards. So, unless there is another reason, I'm considering to backport this. Will keep it open for some hours, awaiting for feedback.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Hehe, great, by mistake I already have pushed it to all branches (I performed an incorrect reset, grrr). So if there is any reason to revert them, plz, tell me.

            Integrated (23, 24, 25 and master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Hehe, great, by mistake I already have pushed it to all branches (I performed an incorrect reset, grrr). So if there is any reason to revert them, plz, tell me. Integrated (23, 24, 25 and master), thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            (this has been already tested against all branches, and passes, just awaiting from some feedback from Ankit in case it's not ok to have them in stables for some unknown reason)

            Show
            Eloy Lafuente (stronk7) added a comment - (this has been already tested against all branches, and passes, just awaiting from some feedback from Ankit in case it's not ok to have them in stables for some unknown reason)
            Hide
            Ankit Agarwal added a comment -

            Hi Eloy,
            It is okay to backport the tests to stable branches. I was under the impression that any new code including tests cannot go in stable.
            +1 for backport.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi Eloy, It is okay to backport the tests to stable branches. I was under the impression that any new code including tests cannot go in stable. +1 for backport. Thanks
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Thanks for giving me joys and smiles
            Thanks for sharing my trouble's pile

            Thanks for wipeing the tears of my eye
            Thanks for showing me the glad view of sky

            Thanks for lending me your shoulders to lean
            Thanks for giving my words a proper mean

            Thanks for telling me the value of life
            Thanks for showing me the rules to survive

            Thanks for lending me the sympathetic ears
            Thanks for showing how much you care

            From all this what I mean in the end
            Is thanks for being my special friend.

            – Seema Chowdhury

            Sent upstream so... closing, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Thanks for giving me joys and smiles Thanks for sharing my trouble's pile Thanks for wipeing the tears of my eye Thanks for showing me the glad view of sky Thanks for lending me your shoulders to lean Thanks for giving my words a proper mean Thanks for telling me the value of life Thanks for showing me the rules to survive Thanks for lending me the sympathetic ears Thanks for showing how much you care From all this what I mean in the end Is thanks for being my special friend. – Seema Chowdhury Sent upstream so... closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Agile