Moodle
  1. Moodle
  2. MDL-40260

Regression: In Course overview block, all MNET courses are dimmed

    Details

    • Testing Instructions:
      Hide

      Requires 2 Moodle sites configured with MNET and one that allows enrolment into the other sites courses.
      Login as a user that is enrolled in courses from the other MNET Moodle site.
      Check to make sure the courses are listed without being "dimmed"

      Show
      Requires 2 Moodle sites configured with MNET and one that allows enrolment into the other sites courses. Login as a user that is enrolled in courses from the other MNET Moodle site. Check to make sure the courses are listed without being "dimmed"
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      master_MDL-40260

      Description

      The fix implemented from MDL-37968 causes all MNET courses to be dimmed. The visible attribute does not exist locally for MNET courses, and unavailable courses do not appear, so any MNET courses that display will be available and should not be dimmed.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Daniel Myers added a comment - - edited

            I attached a patch we came up with to fix the issue.

            Show
            Daniel Myers added a comment - - edited I attached a patch we came up with to fix the issue.
            Hide
            Dan Marsden added a comment -

            whoops

            Show
            Dan Marsden added a comment - whoops
            Hide
            Dan Marsden added a comment -

            linking up previous bug - unfortunately I haven't got time to look this weekend and next week I'm at the Melbourne moot - hopefully someone else can pick this up in the meantime - thanks for the report!

            Show
            Dan Marsden added a comment - linking up previous bug - unfortunately I haven't got time to look this weekend and next week I'm at the Melbourne moot - hopefully someone else can pick this up in the meantime - thanks for the report!
            Hide
            Damyon Wiese added a comment -

            Thanks for the patch Daniel, and thanks for pushing it through Dan.

            Integrated to 24, 25 and master. I made a trivial commit in integration to boost my commit count make the code a little neater.

            Show
            Damyon Wiese added a comment - Thanks for the patch Daniel, and thanks for pushing it through Dan. Integrated to 24, 25 and master. I made a trivial commit in integration to boost my commit count make the code a little neater.
            Hide
            Rossiani Wijaya added a comment -

            This is working as expected.

            Tested for 2.4, 2.5 and master.

            Test passed.

            Show
            Rossiani Wijaya added a comment - This is working as expected. Tested for 2.4, 2.5 and master. Test passed.
            Hide
            Damyon Wiese added a comment -

            Thanks again for another week of fixes, improvements and testing. These changes have been released to the world.

            Cheers, Damyon

            Show
            Damyon Wiese added a comment - Thanks again for another week of fixes, improvements and testing. These changes have been released to the world. Cheers, Damyon

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: