-
Improvement
-
Resolution: Won't Do
-
Minor
-
None
-
2.5.1
-
MOODLE_25_STABLE
One of the functions of the login_info renderer is to query the database and report failed logins to admins under certain conditions (just logged in, admin setting for this is on)
This has two main issues:
1. Complicated, database related code in a renderer area
2. Limiting your options when changing this area since you have to account for this possibility
Both are in a place that people might want to customise in order to match their other website's login interface.
Ideally this code would be moved somewhere else, possibly using the messaging system to notify interested parties.