Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40277 Investigate performance issues with course/manage.php and associated
  3. MDL-40280

coursecat::make_categories_list when called multiple times can be slow

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Caching, Course
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE

      Description

      To build the list of dropdowns used to move a category on course/manage.php, coursecat::make_categories_list is called once per category.

      The only difference is to specify the current category so that it is not included in the array. This leads to $categorycount calls to coursecat::make_categories_list() with almost identical data.

      We could either use a MUC or static cache in print_category_edit() to only call make_categories_list once, or improve coursecat::make_categories_list() to return the cached copy earlier somehow.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              dobedobedoh Andrew Lyons
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              5 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: