Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40277 Investigate performance issues with course/manage.php and associated
  3. MDL-40280

coursecat::make_categories_list when called multiple times can be slow

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • 2.5
    • Caching, Course
    • MOODLE_25_STABLE

      To build the list of dropdowns used to move a category on course/manage.php, coursecat::make_categories_list is called once per category.

      The only difference is to specify the current category so that it is not included in the array. This leads to $categorycount calls to coursecat::make_categories_list() with almost identical data.

      We could either use a MUC or static cache in print_category_edit() to only call make_categories_list once, or improve coursecat::make_categories_list() to return the cached copy earlier somehow.

        1. 0001-MDL-40280-Improve-performance-of-coursecat-make_cate.patch
          3 kB
          Andrew Lyons
        2. best after run - callgraph.png
          159 kB
          Andrew Lyons
        3. best after run - detail.png
          104 kB
          Andrew Lyons
        4. best before run - callgraph.png
          168 kB
          Andrew Lyons
        5. best before run - detail.png
          110 kB
          Andrew Lyons
        6. comparison.png
          49 kB
          Andrew Lyons
        7. comparison - detail.png
          81 kB
          Andrew Lyons
        8. make_categories_list - base.png
          172 kB
          Andrew Lyons
        9. make_categories_list - base - callgraph.png
          361 kB
          Andrew Lyons
        10. make_categories_list - caching named path.png
          141 kB
          Andrew Lyons
        11. make_categories_list - caching named path - callgraph.png
          311 kB
          Andrew Lyons
        12. Screen Shot 2013-06-21 at 12.55.09.png
          43 kB
          Andrew Lyons

            Unassigned Unassigned
            dobedobedoh Andrew Lyons
            Votes:
            5 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.