Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40286

non-editing teacher should see Grade analysis in Lesson

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5, 2.7.4, 2.8.2, 2.9
    • Fix Version/s: 2.9
    • Component/s: Lesson
    • Testing Instructions:
      Hide

      Create a graded lesson with some question pages
      As a student attempt the lesson.
      Verify that connected as both a teacher and as a non editing teacher you can access the lesson statistics.

      • clicking on the "Reports" tab or following Reports -> Overview and Reports ->Detailed statistics in the lesson administration menu
      • from the gradebook when you click on the magnifying glass near a student grade for the lesson

      Remove the mod/lesson:viewreports capability from a teacher or non editing teacher and verify you can no more access lesson statistics from anywhere.

      Show
      Create a graded lesson with some question pages As a student attempt the lesson. Verify that connected as both a teacher and as a non editing teacher you can access the lesson statistics. clicking on the "Reports" tab or following Reports -> Overview and Reports ->Detailed statistics in the lesson administration menu from the gradebook when you click on the magnifying glass near a student grade for the lesson Remove the mod/lesson:viewreports capability from a teacher or non editing teacher and verify you can no more access lesson statistics from anywhere.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:

      Description

      There is a wrong capability in mod/lesson/grade.php for viewing grade analysis (Lesson reports).
      Replace :

      if (has_capability('mod/lesson:edit', context_module::instance($cm->id))) {
      

      with

      if (has_capability('mod/lesson:manage', context_module::instance($cm->id))) {
      

      The non-editing teacher (aka "tutor") IS allowed to view lesson reports.

        Attachments

          Activity

            People

            Assignee:
            jmvedrine Jean-Michel Vedrine
            Reporter:
            rezeau Joseph Rézeau
            Peer reviewer:
            Andrew Davis Andrew Davis
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Mark Nelson Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15