[MDL-40286] non-editing teacher should see Grade analysis in Lesson - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
git://github.com/jmvedrine/moodle.git
Pull Master Branch:
~~MDL-40286~~
Pull Master Diff URL:
https://github.com/jmvedrine/moodle/compare/master...MDL-40286
Testing Instructions:
Hide

Create a graded lesson with some question pages
As a student attempt the lesson.
Verify that connected as both a teacher and as a non editing teacher you can access the lesson statistics.

clicking on the "Reports" tab or following Reports -> Overview and Reports ->Detailed statistics in the lesson administration menu

from the gradebook when you click on the magnifying glass near a student grade for the lesson

Remove the mod/lesson:viewreports capability from a teacher or non editing teacher and verify you can no more access lesson statistics from anywhere.
Show
Create a graded lesson with some question pages As a student attempt the lesson. Verify that connected as both a teacher and as a non editing teacher you can access the lesson statistics. clicking on the "Reports" tab or following Reports -> Overview and Reports ->Detailed statistics in the lesson administration menu from the gradebook when you click on the magnifying glass near a student grade for the lesson Remove the mod/lesson:viewreports capability from a teacher or non editing teacher and verify you can no more access lesson statistics from anywhere.

There is a wrong capability in mod/lesson/grade.php for viewing grade analysis (Lesson reports).
Replace :

if (has_capability('mod/lesson:edit', context_module::instance($cm->id))) {

with

if (has_capability('mod/lesson:manage', context_module::instance($cm->id))) {

The non-editing teacher (aka "tutor") IS allowed to view lesson reports.

Participants:: Andrew Davis, Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Jean-Michel Vedrine, Joseph Rézeau, Mark Nelson, Mary Cooch, Michael de Raadt

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie