Moodle
  1. Moodle
  2. MDL-40304

improve the compliancy to coding rules in formal_white

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: Themes
    • Labels:
      None
    • Testing Instructions:
      Hide

      Nothing should change as only comments were involved in this patch.
      As final test, the execution of the code-checker by Tim and Eloy should report less issues than before.

      Show
      Nothing should change as only comments were involved in this patch. As final test, the execution of the code-checker by Tim and Eloy should report less issues than before.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40304_master

      Description

      Change the code of formal_white to get compliancy to coding rules as described by code_checker

        Gliffy Diagrams

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, passing this now.

          Show
          Sam Hemelryk added a comment - Thanks guys, passing this now.
          Hide
          Daniele Cordella added a comment -

          Thanks Sam, it is always a pleasure to work with you and Andrea!

          Show
          Daniele Cordella added a comment - Thanks Sam, it is always a pleasure to work with you and Andrea!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Thanks for giving me joys and smiles
          Thanks for sharing my trouble's pile

          Thanks for wipeing the tears of my eye
          Thanks for showing me the glad view of sky

          Thanks for lending me your shoulders to lean
          Thanks for giving my words a proper mean

          Thanks for telling me the value of life
          Thanks for showing me the rules to survive

          Thanks for lending me the sympathetic ears
          Thanks for showing how much you care

          From all this what I mean in the end
          Is thanks for being my special friend.

          – Seema Chowdhury

          Sent upstream so... closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Thanks for giving me joys and smiles Thanks for sharing my trouble's pile Thanks for wipeing the tears of my eye Thanks for showing me the glad view of sky Thanks for lending me your shoulders to lean Thanks for giving my words a proper mean Thanks for telling me the value of life Thanks for showing me the rules to survive Thanks for lending me the sympathetic ears Thanks for showing how much you care From all this what I mean in the end Is thanks for being my special friend. – Seema Chowdhury Sent upstream so... closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: