Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40323

Strict standards warning on Site Administration > Reports > Logs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.4
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Logging, Reports
    • Labels:

      Description

      Accessing Reports > Logs > Reports > Logs with debugging on throws this error message:

      Strict Standards: Creating default object from empty value in ../report/log/locallib.php on line 354

      Observed in 2.4.4 but the code in question is present in current master.

        Gliffy Diagrams

          Activity

          Hide
          ankit_frenz Ankit Agarwal added a comment -

          Hi Charles,
          The patch looks great. Please add some testing instructions and feel free to submit for integration.
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - Hi Charles, The patch looks great. Please add some testing instructions and feel free to submit for integration. Thanks
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          I have added some instructions, submitting for integration.
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - I have added some instructions, submitting for integration. Thanks
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated to master and cherry-picked to 25 and 24 - thanks Charles!

          Show
          poltawski Dan Poltawski added a comment - Integrated to master and cherry-picked to 25 and 24 - thanks Charles!
          Hide
          abgreeve Adrian Greeve added a comment -

          Tested on the master integration branch.
          No warnings found.
          Test passed.

          Show
          abgreeve Adrian Greeve added a comment - Tested on the master integration branch. No warnings found. Test passed.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!

          "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
          Adams, D (1992) Mostly Harmless. London: William Heinemann.

          Show
          samhemelryk Sam Hemelryk added a comment - Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you! "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office." Adams, D (1992) Mostly Harmless. London: William Heinemann.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13