Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.4.4
-
Labels:
-
Testing Instructions:
- Goto Accessing Reports > Logs > Reports > Logs
- Search for logs, using various combination of settings, make sure no error is thrown.
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-40323-master -
Pull Master Diff URL:
Description
Accessing Reports > Logs > Reports > Logs with debugging on throws this error message:
Strict Standards: Creating default object from empty value in ../report/log/locallib.php on line 354
Observed in 2.4.4 but the code in question is present in current master.
Gliffy Diagrams
Activity
I have added some instructions, submitting for integration.
Thanks
Integrated to master and cherry-picked to 25 and 24 - thanks Charles!
Tested on the master integration branch.
No warnings found.
Test passed. 
Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!
"It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
Adams, D (1992) Mostly Harmless. London: William Heinemann.
Hi Charles,
The patch looks great. Please add some testing instructions and feel free to submit for integration.
Thanks