Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40347

Grader report (gradebook) is not highlighting the last row properly

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.5
    • 2.6
    • Gradebook
    • MOODLE_25_STABLE
    • MOODLE_26_STABLE
    • wip-MDL-40347-master
    • Hide

      First, we need to make sure that grader report displays all possible rows and columns:

      1. Create course with several graded activities, enrol several students
      2. Enable groups for the course, create group, add some students to it
      3. Create grading categories and subcategories, place some activities inside
      4. Open settings for grader report and select 'show' to everything that can be shown

      Test:

      1. Open grader report for the course, select a group so the "group average" row is added as well
      2. Try clicking on columns and rows headers and make sure that all cells in the column/row are properly highlighted
      3. Repeat test in themes: Standard, MyMobile, Clean and maybe some other themes.

      Note: MyMobile theme makes highlighting invisible

      Show
      First, we need to make sure that grader report displays all possible rows and columns: Create course with several graded activities, enrol several students Enable groups for the course, create group, add some students to it Create grading categories and subcategories, place some activities inside Open settings for grader report and select 'show' to everything that can be shown Test: Open grader report for the course, select a group so the "group average" row is added as well Try clicking on columns and rows headers and make sure that all cells in the column/row are properly highlighted Repeat test in themes: Standard, MyMobile, Clean and maybe some other themes. Note: MyMobile theme makes highlighting invisible

    Description

      This was discovered while working on MDL-40131.
      When clicking on row header (outside of the link) in the grader report the column is highlighted but the wrong cell is highlighted in the average row and no cell is highlighted in average range row (have to be enabled in grader report settings).

      Standard (base) theme is masking it by overwriting the CSS so the highlighting the average cell is not visible. Bootstrap has to do the same in 2.5 because it was noticed too late.

      Suggestion: Both average rows (ranges and actual averages) should have the same table cell tag (probably td because it is strange to make the last row a "header" row). Javascript should be fixed to highlight the correct cells in the last row. In order to do it we should assign proper id to the cells in the average rows as it is done for the user grades ($itemcell->id = 'u'.$userid.'i'.$itemid. Javascript should look at cell ids and not at the column number. Who knows maybe somebody adds more student columns in the left part of the table, they do not need to correct JS in this case.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41688 Clean / Bootstrap theme: Gradebook rows are mis-aligned when static student column is enabled

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43186 Gradebook page is oddly proportioned when using Clean and editing on

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40131 Clean (Theme) - in gradebook when clicking the activity title it should highlight the column but not other random cells (see image)

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39777 Remove custom layouts from the clean theme.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Improvement - An enhancement to an existing Moodle feature. MDL-40372 META: Re-integrate mod CSS excluded from Bootstrapbase

          • Major - Major loss of function, incorrect output
          • Closed
          will help resolve

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40534 Re-integrate grade CSS excluded from Bootstrapbase

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              marina Marina Glancy
              marina Marina Glancy
              Marina Glancy Marina Glancy
              Damyon Wiese Damyon Wiese
              Mark Nelson Mark Nelson
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              3 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13