Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40347

Grader report (gradebook) is not highlighting the last row properly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      First, we need to make sure that grader report displays all possible rows and columns:

      1. Create course with several graded activities, enrol several students
      2. Enable groups for the course, create group, add some students to it
      3. Create grading categories and subcategories, place some activities inside
      4. Open settings for grader report and select 'show' to everything that can be shown

      Test:

      1. Open grader report for the course, select a group so the "group average" row is added as well
      2. Try clicking on columns and rows headers and make sure that all cells in the column/row are properly highlighted
      3. Repeat test in themes: Standard, MyMobile, Clean and maybe some other themes.

      Note: MyMobile theme makes highlighting invisible

      Show
      First, we need to make sure that grader report displays all possible rows and columns: Create course with several graded activities, enrol several students Enable groups for the course, create group, add some students to it Create grading categories and subcategories, place some activities inside Open settings for grader report and select 'show' to everything that can be shown Test: Open grader report for the course, select a group so the "group average" row is added as well Try clicking on columns and rows headers and make sure that all cells in the column/row are properly highlighted Repeat test in themes: Standard, MyMobile, Clean and maybe some other themes. Note: MyMobile theme makes highlighting invisible
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-40347-master

      Description

      This was discovered while working on MDL-40131.
      When clicking on row header (outside of the link) in the grader report the column is highlighted but the wrong cell is highlighted in the average row and no cell is highlighted in average range row (have to be enabled in grader report settings).

      Standard (base) theme is masking it by overwriting the CSS so the highlighting the average cell is not visible. Bootstrap has to do the same in 2.5 because it was noticed too late.

      Suggestion: Both average rows (ranges and actual averages) should have the same table cell tag (probably td because it is strange to make the last row a "header" row). Javascript should be fixed to highlight the correct cells in the last row. In order to do it we should assign proper id to the cells in the average rows as it is done for the user grades ($itemcell->id = 'u'.$userid.'i'.$itemid. Javascript should look at cell ids and not at the column number. Who knows maybe somebody adds more student columns in the left part of the table, they do not need to correct JS in this case.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13