Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40371

Remove unused *_upgrade_grades

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      can only be 'tested' by a developer.
      Grep/search for *_upgrade_grades to make sure they aren't used anymore.

      A full Behat & PHPunit run (by the CI sever) will do a good job of confirming tha this does not cause any regressions.

      Show
      can only be 'tested' by a developer. Grep/search for *_upgrade_grades to make sure they aren't used anymore. A full Behat & PHPunit run (by the CI sever) will do a good job of confirming tha this does not cause any regressions.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      master_MDL-40371

      Description

      Grepping through the 2.7 Moodle code, I see that these functions exist:

      mod/data/lib.php:1071:function data_upgrade_grades() {
      mod/forum/lib.php:858:function forum_upgrade_grades() {
      mod/glossary/lib.php:777:function glossary_upgrade_grades() {
      mod/lesson/lib.php:417:function lesson_upgrade_grades() {
      mod/quiz/lib.php:636:function quiz_upgrade_grades() {
      mod/scorm/lib.php:626:function scorm_upgrade_grades() {

      These were used in Moodle 2.2, but there is no code that calls them since Moodle 2.3.

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            brianking Brian King
            Peer reviewer:
            Tim Hunt Tim Hunt
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Rajesh Taneja Rajesh Taneja
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Dan Marsden, Matteo Scaramuccia, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Nov/14