Moodle
  1. Moodle
  2. MDL-40386

timemodified in mdl_book_chapters doesn't auto-update

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Book
    • Labels:
    • Rank:
      51170

      Description

      While updating certain chapters within a book module, I noticed that the timemodified field of those chapters and that book weren't being updated in the database's mdl_book_chapters and mdl_book tables respectively.

      I guess, if a chapter if updated, the timemodified fields of both the book and chapter should be updated.

        Activity

        Hide
        Prateek Sachan added a comment - - edited

        Please cherry-pick for the rest Stable Moodle versions.

        [Edit]: I've provided the fix for timemodified field in book_chapters only (on update of chapters), as I'm not sure whether updating timemodified field of book is a good approach or not.

        Show
        Prateek Sachan added a comment - - edited Please cherry-pick for the rest Stable Moodle versions. [Edit] : I've provided the fix for timemodified field in book_chapters only (on update of chapters), as I'm not sure whether updating timemodified field of book is a good approach or not.
        Hide
        Aparup Banerjee added a comment -

        looks good Prateek! sending for integration.

        Michael, can we assign this issue to Prateek ?

        Show
        Aparup Banerjee added a comment - looks good Prateek! sending for integration. Michael, can we assign this issue to Prateek ?
        Hide
        Michael de Raadt added a comment -

        Yes, we can.

        The testing instructions could be expanded.

        Prateek:

        I have added you to the jira-developers group. You are now able to edit issues, assign issues to yourself and submit issues for peer review. For more details, please see http://docs.moodle.org/dev/Tracker_guide#Tracker_groups_and_permissions

        Thanks for your efforts.

        Show
        Michael de Raadt added a comment - Yes, we can. The testing instructions could be expanded. Prateek: I have added you to the jira-developers group. You are now able to edit issues, assign issues to yourself and submit issues for peer review. For more details, please see http://docs.moodle.org/dev/Tracker_guide#Tracker_groups_and_permissions Thanks for your efforts.
        Hide
        Prateek Sachan added a comment -

        Thanks Aparup and Michael.

        I've edited the Testing Instructions for clarity.

        Show
        Prateek Sachan added a comment - Thanks Aparup and Michael. I've edited the Testing Instructions for clarity.
        Hide
        Damyon Wiese added a comment - - edited

        Thanks Prateek - one thing to note is to make sure you fill out the Repository URL field in the tracker. This makes the integrators life easier when we have lots of repositories/patches to look at.

        Also the branch name should just be the name of the branch - not the url.

        Show
        Damyon Wiese added a comment - - edited Thanks Prateek - one thing to note is to make sure you fill out the Repository URL field in the tracker. This makes the integrators life easier when we have lots of repositories/patches to look at. Also the branch name should just be the name of the branch - not the url.
        Hide
        Damyon Wiese added a comment -

        Thanks for working on this Prateek,

        I've integrated this to 24, 25 and master branches.

        Show
        Damyon Wiese added a comment - Thanks for working on this Prateek, I've integrated this to 24, 25 and master branches.
        Hide
        Prateek Sachan added a comment -

        Thanks Damyon. I'll remember the things you've pointed out.

        Show
        Prateek Sachan added a comment - Thanks Damyon. I'll remember the things you've pointed out.
        Hide
        David Monllaó added a comment -

        It passes. Tested in 24, 25 and master

        Show
        David Monllaó added a comment - It passes. Tested in 24, 25 and master
        Hide
        Damyon Wiese added a comment -

        a single bug fix
        a drop in a waterfall
        hear the mighty roar

        Thanks for your contribution!

        Show
        Damyon Wiese added a comment - a single bug fix a drop in a waterfall hear the mighty roar Thanks for your contribution!

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: