Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.5
-
Component/s: Unit tests
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_25_STABLE
-
Fixed Branches:MOODLE_24_STABLE, MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip_
MDL-40388_v2 -
Pull Master Diff URL:
Description
I am introducing testing for processing of submitted form contents. We need to inject the test form data through the _POST or _GET and _FILES variable. The unit test framework should handle the resetting of these global vars after each test.
Gliffy Diagrams
Attachments
Issue Links
- will help resolve
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
oh, you have forgotten _REQUEST. Also in CLI scripts these global variables are always empty. Maybe we could just empty them without any warning.
Just do this you mean Petr : https://github.com/jamiepratt/moodle/compare/wip_MDL-40388_v2
I agree that there is no need to keep a copy of the global vars, just setting them to an empty array as they would be before the unit test makes sense.
+1
Updated branch and compare link to point to new branch after input from Petr.
+1, sending to integration, I vote for 2.5 branch + master because there is no risk of regression
Testing this now on 24, 25 and master - this is a testing framework issue so it's ok for backports.
One thing I noticed is the multiple lines of whitespace. I'll clean this in the patch once the tests pass.
Thanks for this and for cleaning up those stray newlines Damyon. Will try to be more careful in future.
Thanks Jamie,
Integrated to 24, 25 and master.
I forgot to clean the blank lines before I pushed - but no big deal.
Marking this as passed as I ran unit tests on all branches in integration.
a single bug fix
a drop in a waterfall
hear the mighty roar
Thanks for your contribution!
Linking this issue to the issue about the new formslib mock_submit method.