Sending to peer-review.

Note this is blocked by MDL-40297 and requires it integrated to get this passing.

Hi Eloy,

I don't feel especially qualified to peer review this.

But channelling my 'inner david', I think that he would ask if there is a better way to write the 'block selector' (i.e. using a human way of writing it). However, having looked at some other examples, I see that he has selected things this way in some other tests, so I guess that this is the most pragmatic way of doing it at the moment.

So, I tink its good to go, or if you prefer to wait for david..

Note I've added some thoughts in the commit message about to create some higher level selectors in the future.

Also I've shared those thoughts (and this issue) already with David (offline jabber) and also have them annotated to be added to the next week testing meeting.

Anyway, this is not really critical, the only point was to provide automated testing for MDL-40297, but that one contains human instructions too, so can wait, np. Let David take a look to it and decide to send it to integration.

Thanks and ciao

Hi,

It looks good, the only thing I can think of and you might be interested in considering is non-JS tests, but not required.

About the selectors and the commit msg, it would be a good way to do it, also easier for no-nerds that wants to contribute feature files, we can open an issue for discussion, we can manage it in a single step as proposed or have different steps as (for example) header does not need a var. would be just I should see "Eloy likes colacao" in the page header

1) Colacao is always with the 1st (at least) upper!
2) I was talking about the moodle "header" (part of body). NVM.
3) +1 to create an issue to discuss new language constructors that maybe interesting to be added. Perhaps asking for ideas @ HQ/devs. People can be really imaginative there.

Ciao

Behat tests pass for me with this change - I'll push it later (about to head home).

Thanks Eloy

I have integrated this to 25 and master now.

I kept getting the annoying error "Unknown error 1 This is not a behat test site!" when trying to run "php admin/tool/behat/cli/init.php" so I dropped all the behat database tables and was able to initialise the behat site. Anyways, besides this, I ran the tests with no issues.

a single bug fix
a drop in a waterfall
hear the mighty roar

Thanks for your contribution!