Details

    • Testing Instructions:
      Hide

      Go into a course and add (or edit) and activity. After loading, the editor box should be large enough for a reasonable amount of simple editing.

      Note - this may have to be done with a cleared browser, as TinyMCE does 'remember' if you resized the box in the pase.

      Show
      Go into a course and add (or edit) and activity. After loading, the editor box should be large enough for a reasonable amount of simple editing. Note - this may have to be done with a cleared browser, as TinyMCE does 'remember' if you resized the box in the pase.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:

      Description

      The default description field size for activities has become too small after the patch from MDL-38614. It is only about 1.5 lines tall (see screenshot), and to make matters worse, the collapsed version of the editor doesn't allow you to resize the edit area.

      While I understand the need point of MDL-38614, I feel this has gone so far as to hamper usability. Especially given the reduced size of the collapsed editor, it seems unnecessary to make the field that small.

        Gliffy Diagrams

        1. LessTinyBox.png
          26 kB
        2. TinyBox.png
          31 kB

          Issue Links

            Activity

            Hide
            Eric Merrill added a comment -

            MDL-39351 has some very good comments on this behavior/why it happens, and some comments from Martin that (to me) say this is a bad thing®.

            Show
            Eric Merrill added a comment - MDL-39351 has some very good comments on this behavior/why it happens, and some comments from Martin that (to me) say this is a bad thing®.
            Hide
            Eric Merrill added a comment -

            I've change the size to 10 lines (which actually gives you 3 lines of useable space). I think this is a good compromise between size and usability. See attached screenshot.

            Show
            Eric Merrill added a comment - I've change the size to 10 lines (which actually gives you 3 lines of useable space). I think this is a good compromise between size and usability. See attached screenshot.
            Hide
            Eric Merrill added a comment -

            Based on the discussion in MDL-38614, I've added Tim, Frédéric, and Dan as watchers to this. If you guys put in your two cents on this (or obviously just feel free to take your self off it it). Thanks.

            Show
            Eric Merrill added a comment - Based on the discussion in MDL-38614 , I've added Tim, Frédéric, and Dan as watchers to this. If you guys put in your two cents on this (or obviously just feel free to take your self off it it). Thanks.
            Hide
            Tim Hunt added a comment -

            You need to fix the commit comment so that the first line is not too long.

            Apart from that +1 from me.

            Show
            Tim Hunt added a comment - You need to fix the commit comment so that the first line is not too long. Apart from that +1 from me.
            Hide
            Eric Merrill added a comment -

            Thanks Tim. Reworded the commits.

            Show
            Eric Merrill added a comment - Thanks Tim. Reworded the commits.
            Hide
            Frédéric Massart added a comment -

            Hi Eric, thanks for the patch. Despite the fact that this solution only enhance the editor in the mod_form, I also noticed that in the new theme clean, the area gets quite big, would there be a way to have a consistency in the size throughout themes and locations? Cheers!

            Show
            Frédéric Massart added a comment - Hi Eric, thanks for the patch. Despite the fact that this solution only enhance the editor in the mod_form, I also noticed that in the new theme clean, the area gets quite big, would there be a way to have a consistency in the size throughout themes and locations? Cheers!
            Hide
            Eric Merrill added a comment -

            I'm not sure why the Clean theme is rendering it differently - although it does have the same problem when set to number of rows 3 (renders as only 1-1.5 rows tall). When set to 10 (my patch) in the clean theme you get 6 editor rows instead of the 3 that you get in Standard.

            I don't know a ton about Clean (and Bootstrap) and why it would be different, it just seems like there are some weird interactions between bootstrap and TinyMCE.

            IMO, the basic bug is there in all themes (a setting of 3 only gives you 1 lines of editor, which is basically unusable). While I agree that it would be nice to have it be rendered consistent among all themes, I think that it's important to fix the simple usability issue quickly, and it's going to be a big-ish can of worms as to why each theme renders TinyMCE differently with the same settings...

            Show
            Eric Merrill added a comment - I'm not sure why the Clean theme is rendering it differently - although it does have the same problem when set to number of rows 3 (renders as only 1-1.5 rows tall). When set to 10 (my patch) in the clean theme you get 6 editor rows instead of the 3 that you get in Standard. I don't know a ton about Clean (and Bootstrap) and why it would be different, it just seems like there are some weird interactions between bootstrap and TinyMCE. IMO, the basic bug is there in all themes (a setting of 3 only gives you 1 lines of editor, which is basically unusable). While I agree that it would be nice to have it be rendered consistent among all themes, I think that it's important to fix the simple usability issue quickly, and it's going to be a big-ish can of worms as to why each theme renders TinyMCE differently with the same settings...
            Hide
            Jason Fowler added a comment -

            I think this issue needs a patch that fixes it consistently throughout moodle, not just for mforms. And it needs to have the same result it all themes.

            If you could expand the scope of the patch to include other places the HTML editor is used, that would be great.

            The patch itself is fine too.

            Show
            Jason Fowler added a comment - I think this issue needs a patch that fixes it consistently throughout moodle, not just for mforms. And it needs to have the same result it all themes. If you could expand the scope of the patch to include other places the HTML editor is used, that would be great. The patch itself is fine too.
            Hide
            Eric Merrill added a comment -

            This issue is a regression caused by MDL-38614, which only affected this one location.

            That being said, I did the best I can do to review the other instances of editor (without spending hours and hours I don't have), and the only other places that I found with really small editors are in Questions, which is intentional I believe (MDL-39351 I think).

            As for the the inconsistency between themes, that seems unrelated too this issue - as they are all too small right now, and that problem has been around since who knows when. It seems like that should be a different ticket (which I would be glad to open), but it will require the work of one of the handful of people that know tinymce to dig into it, and it seems like that shouldn't block this basic usability issue.

            Show
            Eric Merrill added a comment - This issue is a regression caused by MDL-38614 , which only affected this one location. That being said, I did the best I can do to review the other instances of editor (without spending hours and hours I don't have), and the only other places that I found with really small editors are in Questions, which is intentional I believe ( MDL-39351 I think). As for the the inconsistency between themes, that seems unrelated too this issue - as they are all too small right now, and that problem has been around since who knows when. It seems like that should be a different ticket (which I would be glad to open), but it will require the work of one of the handful of people that know tinymce to dig into it, and it seems like that shouldn't block this basic usability issue.
            Hide
            Dan Poltawski added a comment -

            Right. I agree with Eric's assessment. Fixing up everything is something we should do as HQ, but whilst we're waiting for that, lets get this small bug fixed in the ugly way it already is.

            Sending for integration under my name.

            Show
            Dan Poltawski added a comment - Right. I agree with Eric's assessment. Fixing up everything is something we should do as HQ, but whilst we're waiting for that, lets get this small bug fixed in the ugly way it already is. Sending for integration under my name.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (25 & master), thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (25 & master), thanks!
            Hide
            Andrew Davis added a comment -

            It is indeed far better than in the screenshots. Passing.

            Show
            Andrew Davis added a comment - It is indeed far better than in the screenshots. Passing.
            Hide
            Damyon Wiese added a comment -

            Moodle has many old functions,
            And although they cause no malfunction,
            There comes a day,
            When they get deprecated away,
            And get and put on the list for expulsion.

            Thanks for all the reports/testing/fixes this week. This issue has been sent upstream.

            Show
            Damyon Wiese added a comment - Moodle has many old functions, And although they cause no malfunction, There comes a day, When they get deprecated away, And get and put on the list for expulsion. Thanks for all the reports/testing/fixes this week. This issue has been sent upstream.

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: