Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40442

Icon t/download.png should match t/download.svg

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable badges
      2. As a teacher in a course, create a new badge, set the criteria to manually award it and enable the badge
      3. Award the badge to a student
      4. Login as the stuednt
      5. Go to Preferences > Badges > Manage badges
      6. Inspect the Download icon next to the badge in an SVG capable browser, it should look nice when zoomed
      7. In your config.php set $CFG->svgicons = false;
      8. Refresh page
      9. Verify the icon matches the svg icon but is a png
      Show
      Enable badges As a teacher in a course, create a new badge, set the criteria to manually award it and enable the badge Award the badge to a student Login as the stuednt Go to Preferences > Badges > Manage badges Inspect the Download icon next to the badge in an SVG capable browser, it should look nice when zoomed In your config.php set $CFG->svgicons = false; Refresh page Verify the icon matches the svg icon but is a png
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40442-master
    • Pull Master Diff URL:

      Description

      A new SVG icon has been introduced (MDL-35073), but its PNG fallback is quite different and not in the same style. A PNG should be created from that SVG icon.

      (And I guess the source could even added to the main Illustrator file).

      On a side note, the source of the SVG should be optimised, as the layers are not clean (greater file size, slower rendering?)

        Attachments

        1. wrong.png
          wrong.png
          12 kB
        2. Screen Shot 2015-10-13 at 3.45.52 PM.png
          Screen Shot 2015-10-13 at 3.45.52 PM.png
          104 kB
        3. right.png
          right.png
          12 kB
        4. download.png
          download.png
          0.7 kB

          Issue Links

          is a regression caused by

          New Feature - A new Moodle feature which has yet to be developed. MDL-35073 Open Badges Integration

          • Major - Major loss of function, incorrect output
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51759 $CFG->svgicons set to false can cause images to fail

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              • Assignee:
                barbararamiro Barbara Ramiro
                Reporter:
                fred Frédéric Massart
                Peer reviewer:
                Dan Poltawski
                Integrator:
                Andrew Nicols
                Tester:
                Mark Nelson
                Participants:
                Component watchers:
                Yuliya Bozhko, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Barbara Ramiro, Jake Dallimore, Jun Pataleta, Ryan Wyllie
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Nov/15