Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34311 Improve debugging when using default cleaning
  3. MDL-40469

Fix missing setType calls when exporting gradebook

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.5
    • 2.5.2
    • Gradebook
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • wip-mdl-40469
    • Hide

      Prerequisite

      1. course with few activities and users having gardes

      Test

      1. Log in as admin
      2. Enable gradepublishing
      3. Go to course and click on Grades
      4. Click on Key manager (Grade administration > Export> Key manager).
      5. Make sure no setType warning appears
      6. Add new key and make sure it gets added without any problem.
      7. Export grades as "Plain text file" (Grade administration > Export> Plain text file)
      8. Make sure no setType warning appears and you can export grades without any problem.
      Show
      Prerequisite course with few activities and users having gardes Test Log in as admin Enable gradepublishing Go to course and click on Grades Click on Key manager (Grade administration > Export > Key manager). Make sure no setType warning appears Add new key and make sure it gets added without any problem. Export grades as "Plain text file" (Grade administration > Export > Plain text file) Make sure no setType warning appears and you can export grades without any problem.

    Description

      With gradepublishing set, try export gradebook as plain text and you will see following warning:

      Did you remember to call setType() for 'iprestriction'? Defaulting to PARAM_RAW cleaning.
       
          line 1303 of /lib/formslib.php: call to debugging()
          line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
          line 202 of /lib/formslib.php: call to moodleform->_process_submission()
          line 43 of /grade/export/txt/index.php: call to moodleform->moodleform()
      

      While generating user key (Grades ► User keys ► Create user key), you will see following warning:

      Did you remember to call setType() for 'iprestriction'? Defaulting to PARAM_RAW cleaning.
       
          line 1303 of /lib/formslib.php: call to debugging()
          line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
          line 202 of /lib/formslib.php: call to moodleform->_process_submission()
          line 92 of /grade/export/key.php: call to moodleform->moodleform()
      

      Attachments

        Issue Links

          Activity

            People

              rajeshtaneja Rajesh Taneja
              rajeshtaneja Rajesh Taneja
              Ankit Agarwal Ankit Agarwal
              Sam Hemelryk Sam Hemelryk
              Rossiani Wijaya Rossiani Wijaya
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13