Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40470

url_select triggers on click not on change.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      In as many browsers as possible:

      • IE8
      • IE9
      • IE10
      • Firefox
      • Chrome
      • iOS Safari
      • iOS Chrome
      • Android
      • Chrome Android
      • Whatever else you can find

      Testing instructions:

      • Open a course
      • Turn editing on
      • Click the "Add block..." dropdown
      • Close it (by clicking on it) it again without making a selection
        • Confirm no change
      • Hit enter (keyboard) to open it again
      • Hit enter (keyboard) to close it again
        • Confirm no change
      • Use the mouse to select an item from the "Add block..." dropdown
        • Confirm that it was added
      • Use the keyboard to select an item from the "Add block..." dropdown
        • Confirm that it was added
      • Add a new assignment
        • Set the feedback type to the "Offline grading worksheet"
      • Open the activity
      • View/grade all submissions
      • From the dropdown choose "Download grading worksheet"
        • Confirm that you were prompted to download the file
        • Click cancel
      • Click the dropdown again and change it to the top option
        • Confirm that there was no change, and you weren't promped to download the file again

      Note: Opera used to not handle some items properly - keyboard IIRC. This may be fixed now they've moved to Blink.

      Show
      In as many browsers as possible: IE8 IE9 IE10 Firefox Chrome iOS Safari iOS Chrome Android Chrome Android Whatever else you can find Testing instructions: Open a course Turn editing on Click the "Add block..." dropdown Close it (by clicking on it) it again without making a selection Confirm no change Hit enter (keyboard) to open it again Hit enter (keyboard) to close it again Confirm no change Use the mouse to select an item from the "Add block..." dropdown Confirm that it was added Use the keyboard to select an item from the "Add block..." dropdown Confirm that it was added Add a new assignment Set the feedback type to the "Offline grading worksheet" Open the activity View/grade all submissions From the dropdown choose "Download grading worksheet" Confirm that you were prompted to download the file Click cancel Click the dropdown again and change it to the top option Confirm that there was no change, and you weren't promped to download the file again Note: Opera used to not handle some items properly - keyboard IIRC. This may be fixed now they've moved to Blink.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40470-master

      Description

      I fixed this issue a while ago (sorry, can't find tracker issue), but it seems the code has been changed in 2.5 onwards so the issue is present again.

      1. Visit a course.
      2. Create an assignment.
      3. Check 'Offline grading worksheet' under 'Feedback types'.
      4. Click on the assignment link.
      5. Click 'View/grade all submissions'.
      6. In the select box labelled 'Grading action' choose 'Download grading worksheet'.
      7. When the pop-up appears to download the file, click 'cancel' and remain on the page.
      8. Attempt to change this to 'Upload grading worksheet' and notice that the download grading worksheet action is triggered.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Nov/13