Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40473

Add-on installer not validating plugins requiring plugins not yet installed.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Deferred
    • Affects Version/s: 2.5
    • Fix Version/s: None
    • Component/s: Installation
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE
    • Workaround:
      Hide

      type in url to tool/installaddon/index.php and use UI to install plugin via download.
      OR
      For a plugin author: Place a warning about that bug in the description of you plugin, so that admins will know this beforehand. Put a link to download archive with all dependencies from somewhere else, as Moodle Plugins database don't allow you to do this.

      Show
      type in url to tool/installaddon/index.php and use UI to install plugin via download. OR For a plugin author: Place a warning about that bug in the description of you plugin, so that admins will know this beforehand. Put a link to download archive with all dependencies from somewhere else, as Moodle Plugins database don't allow you to do this.
    • Testing Instructions:
      Hide

      You will need Moodle site connected to internet. All traces of installing qtype_preg (or qtype_pmatchjme) and their dependencies should be deleted from there.

      1. Login as admin and try to install qtype_preg (or qtype_pmatchjme) via web interface from you site.
      2. After redirecting to the Plugins check page, you'll see dependencies that not installed (5 for qtype_preg, one for qtype_pmatchjme), they should have "Install this plugin" buttons near them.
      3. Pressing "Install this plugin" buttons and confirming install ensure, that you could install all the dependencies and finally pass Plugins check.

      Show
      You will need Moodle site connected to internet. All traces of installing qtype_preg (or qtype_pmatchjme) and their dependencies should be deleted from there. 1. Login as admin and try to install qtype_preg (or qtype_pmatchjme) via web interface from you site. 2. After redirecting to the Plugins check page, you'll see dependencies that not installed (5 for qtype_preg, one for qtype_pmatchjme), they should have "Install this plugin" buttons near them. 3. Pressing "Install this plugin" buttons and confirming install ensure, that you could install all the dependencies and finally pass Plugins check.
    • Sprint:
      BACKEND Sprint 19
    • Issue size:
      Small

      Description

      I had installed https://moodle.org/plugins/view.php?plugin=qtype_pmatchjme via the plugins directory's install button and installation proceeded to validate it and continue installing.

      The problem arises at the plugins check page when it says it requires plugin qtype_pmatch. I can go to the plugins directory and install this but my moodle, which i'm only administrating via the web UI, is now stuck in telling me that 'qtype_pmatch' is required.

      I think its a quick patch to have the plugin's requirement validated before allowing to proceed with installation so that we can avoid the situation in the last paragraph.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ankit_frenz Ankit Agarwal
              Reporter:
              nebgor Aparup Banerjee
              Peer reviewer:
              David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              7 Vote for this issue
              Watchers:
              15 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: