Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40515

Selecting a section name in the logs report causes a DB error

    XMLWordPrintable

    Details

    • Database:
      PostgreSQL
    • Testing Instructions:
      Hide

      1. Go to a course with activities in more than one section.
      2. From the settings block, go to the Log report for the course (Reports > Log). This will be in the navigation block for earlier versions of moodle.
      3. Verify the activities selector lists topics as bolded groups that you can't select.
      4. Select an activity and click the button to generate the report, verify the results come up as expected.

      Show
      1. Go to a course with activities in more than one section. 2. From the settings block, go to the Log report for the course (Reports > Log). This will be in the navigation block for earlier versions of moodle. 3. Verify the activities selector lists topics as bolded groups that you can't select. 4. Select an activity and click the button to generate the report, verify the results come up as expected.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      When using the log report (Site pages / ► Reports / ► Logs), and picking a course to report logs on, if you then use the activity drop down, but choose a section heading in there (i.e. '-- Topic 1 --') you get a fatal db error on postgres.

      Debug info: ERROR: invalid input syntax for integer: "section1"
      		 
      SELECT COUNT(*)
      		 
      FROM mdl_log l
      		 
      WHERE l.cmid = $1 AND l.time > $2 AND l.time < $3
      		 
      [array (
      		 
      0 => 'section1',
      		 
      1 => 1372946400,
      		 
      2 => 1373032800,
      		 
      )]

      Given the underlying code only deals with a single modid being passed from this form, I believe the topic headings should instead be optgroups that aren't actually meant to be selectable.

      It appears mysql silently doesn't care that you're trying to compare a string on an int field... The error doesn't come up on mysql, but the results displayed are incorrect (you'd expect to maybe see all the logs for that topic, you dont).

        Attachments

          Activity

            People

            Assignee:
            aolley Adam Olley
            Reporter:
            aolley Adam Olley
            Peer reviewer:
            Adrian Greeve
            Integrator:
            Dan Poltawski
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Nov/13