Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.6
    • 2.6
    • Libraries
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-40516-master
    • Hide
      1. CODE REVIEW: ensure only functions which have had previously been through debugging notices are converted.
      2. Browse through moodle and ensure no errors
      3. Git grep for:
        auth_get_plugin_title
        get_default_course_role
        get_default_course_role
        get_list_of_currencies
        get_list_of_countries
        print_simple_box
        print_simple_box_start
        print_simple_box_end
        convert_urls_into_links
        get_emoticons_list_for_help_file
        replace_smilies
        print_headline
        print_heading
        print_heading_block
        print_box
        print_box_start
        print_box_end
        check_theme_arrows
        print_footer
        user_login_string
        blocks_have_content
        blocks_print_group
        blocks_setup
        blocks_preferred_width
        print_table
        link_to_popup_window
        button_to_popup_window
        print_single_button
        print_spacer
        print_user_picture
        emoticonhelpbutton
        print_paging_bar
        notice_yesno
        choose_from_menu_yesno
        choose_from_menu_nested
        print_time_selector
        print_date_selector
        close_window_button
        choose_from_radio
        print_textfield
        print_heading_with_help
        update_tag_button
        update_course_icon
        switchroles_form
        admin_externalpage_print_header
        admin_externalpage_print_footer
      Show
      CODE REVIEW: ensure only functions which have had previously been through debugging notices are converted. Browse through moodle and ensure no errors Git grep for: auth_get_plugin_title get_default_course_role get_default_course_role get_list_of_currencies get_list_of_countries print_simple_box print_simple_box_start print_simple_box_end convert_urls_into_links get_emoticons_list_for_help_file replace_smilies print_headline print_heading print_heading_block print_box print_box_start print_box_end check_theme_arrows print_footer user_login_string blocks_have_content blocks_print_group blocks_setup blocks_preferred_width print_table link_to_popup_window button_to_popup_window print_single_button print_spacer print_user_picture emoticonhelpbutton print_paging_bar notice_yesno choose_from_menu_yesno choose_from_menu_nested print_time_selector print_date_selector close_window_button choose_from_radio print_textfield print_heading_with_help update_tag_button update_course_icon switchroles_form admin_externalpage_print_header admin_externalpage_print_footer
    • BACKEND Sprint 2

    Description

      Code that has been throwing debugging notices since 2.0 should be converted to skeleton functions.

      Attachments

        Issue Links

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Sam Hemelryk Sam Hemelryk
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13