Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40519

Messaging and feedback activity are using deprecated function choose_from_menu()

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.4, 2.5
    • Fix Version/s: 2.4.11
    • Component/s: Feedback, Messages
    • Labels:
    • Testing Instructions:
      Hide

      Bulk Messaging:

      1. Login in as admin
      2. Go to your user profile and disable the html editor in profile settings
      3. Go to a course with some users enrolled
      4. Go to the participants list
      5. Select some users
      6. In "With selected users..." choose 'send a message'

      Feedback activity:

      1. Login as admin
      2. Change your profile setting "When editing text" to "Use standard web forms"
      3. Add a feedback activity to a course page with users enrolled
      4. Set the 'Record user names' setting to 'USers names will be logged and shown with answers'
      5. Go to the feedback activity
      6. Click on Show non-respondents
      Show
      Bulk Messaging: Login in as admin Go to your user profile and disable the html editor in profile settings Go to a course with some users enrolled Go to the participants list Select some users In "With selected users..." choose 'send a message' Feedback activity: Login as admin Change your profile setting "When editing text" to "Use standard web forms" Add a feedback activity to a course page with users enrolled Set the 'Record user names' setting to 'USers names will be logged and shown with answers' Go to the feedback activity Click on Show non-respondents
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40519_master

      Description

      Bulk Messaging:

      1. Login in as admin
      2. Go to your user profile and disable the html editor in profile settings
      3. Go to a course with some users enrolled
      4. Go to the participants list
      5. Select some users
      6. In "With selected users..." choose 'send a message'

        choose_from_menu() has been deprecated. Please change your code to use html_writer::select().
        line 2333 of /lib/deprecatedlib.php: call to debugging()
        line 25 of /user/message.html: call to choose_from_menu()
        line 177 of /user/messageselect.php: call to require()
        line 48 of /user/action_redir.php: call to require_once()
        

      Feedback activity:

      1. Login as admin
      2. Change your profile setting "When editing text" to "Use standard web forms"
      3. Add a feedback activity to a course page with users enrolled
      4. Set the 'Record user names' setting to 'USers names will be logged and shown with answers'
      5. Go to the feedback activity
        # Click on Show non-respondents
      6. Under 'send message' there is a debugging notice

      choose_from_menu() has been deprecated. Please change your code to use html_writer::select().
      line 2333 of /lib/deprecatedlib.php: call to debugging()
      line 288 of /mod/feedback/show_nonrespondents.php: call to choose_from_menu()
      

      (It looks like this should be using a standard element here!)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                poltawski Dan Poltawski
                Integrator:
                Marina Glancy
                Participants:
                Component watchers:
                Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/Jul/14