[MDL-40520] Start HTML Editor (TinyMCE) with directionality‎ and alignment set according to system language (LTR/RTL mode) - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Reopened
Priority: Minor
Resolution: Unresolved
Affects Version/s: 2.5
Fix Version/s: FRONTEND
Component/s: HTML Editor (TinyMCE)
Labels:
- patch
- rtl
- triaged

Affected Branches:
MOODLE_25_STABLE
Pull from Repository:
https://github.com/nadavkav/moodle/
Pull Master Branch:
MDL-40520_master
Pull Master Diff URL:
https://github.com/nadavkav/moodle/compare/MDL-40520_master
Workaround:

Hide

Immediately after TinyMCE starts, user should click LTR/RTL paragraph flow (directionality) button and also LEFT/RIGHT alignment button too, before starting to input any new text.

Show
Immediately after TinyMCE starts, user should click LTR/RTL paragraph flow (directionality) button and also LEFT/RIGHT alignment button too, before starting to input any new text.
Testing Instructions:
Hide

Set current course to RTL (set language to hebrew)

Open any activity with a TinyMCE editor (a Forum post)

Make sure LTR/RTL paragraph flow (directionality) button and also LEFT/RIGHT alignment button are clicked with the proper directionality and alignment according to the current selected course language.

Input some text and switch to HTML mode to see that the proper directionality and text alignment attribute are set into the HTML tags

Publish the post (If in a Forum) and check the incoming email for proper alignment of the email's content

Set current course to LTR (set language to English)

Start the test all over again
Show
Set current course to RTL (set language to hebrew) Open any activity with a TinyMCE editor (a Forum post) Make sure LTR/RTL paragraph flow (directionality) button and also LEFT/RIGHT alignment button are clicked with the proper directionality and alignment according to the current selected course language. Input some text and switch to HTML mode to see that the proper directionality and text alignment attribute are set into the HTML tags Publish the post (If in a Forum) and check the incoming email for proper alignment of the email's content Set current course to LTR (set language to English) Start the test all over again

Description

TinyMCE (HTML Editor) initiates without any consideration related to user's language setting in current context (Course/System) and since the theme's directionality‎ (LTR or RTL) is overlaid onto the editor, it seems to the user that the text he/she input into the editor is properly aligned and it's paragraph directionality‎ flow is properly set. But actually this is not true since the text is saved into Moodle's DB without any HTML alignment and directionality‎ properties.

And then, in many cases, it is send by email (From Forums and Assignments) to the users (mostly RTL users) with very hard to read left aligned text.

I suggest initiating TinyMCE according to user's current_language().

Attachments

Issue Links

duplicates

MDL-40078 Setting TinyMCE directionality and text alignment button according to course language when initiate, to be email friendly

Closed

has been marked as being related by

MDL-37133 Can't click on rtl icon in tiny html editor - no response

Closed

MDL-45227 Add text direction to default ATTO generated markup

Closed

will be (partly) resolved by

MDL-76488 Add text direction to default TinyMCE generated markup

Open

Activity

People

Assignee:: Nadav Kavalerchik

Reporter:: Nadav Kavalerchik

Peer reviewer:: Jason Fowler

Integrator:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Eloy Lafuente (stronk7), Jason Fowler, Matt Porritt, Michael de Raadt, Nadav Kavalerchik, tehila kaplan, Tim Hunt, zeinab

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 05/Jul/13 3:43 PM

Updated:: 26/Nov/22 10:25 PM