Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-4053

Quiz timer no longer floats on screen

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      All

      Description

      http://moodle.org/mod/quiz/view.php?id=2349

      The timer used to float above the page (1.4 and before) ... but it doesn't anymore.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Gustav Delius (gwd2 at york.ac.uk) Friday, 16 September 2005, 04:01 PM:

          It is still working in IE. I have looked at the timer code and can't see anything wrong there (and there hasn't been much change since 1.4). Someone with more knowledge of dynamic positioning and firefox has to take a look at this.

          From Gustav Delius (gwd2 at york.ac.uk) Friday, 16 September 2005, 04:34 PM:

          I assume this is because absolute positioning (which is used to position the timer div) is not really absolute but relative to the parent element. Now that the page structure has become more complex, perhaps firefox has a different idea of what the parent element is from IE. Anyway, this is too complicated for me.

          From Martin Dougiamas (martin at moodle.com) Friday, 16 September 2005, 04:43 PM:

          aaaaaahh, thanks! cc'ing Urs

          From Urs Hunkler (u.hunkler at elearningkontor.de) Wednesday, 21 September 2005, 10:43 PM:

          I looked at the involved php and JavaScript and CSS. For a preliminarily fix to make the floating timer work in FF I committed additional properties in styles.php.

          The JavaScript handling the timer does not work in FF, it is not cross browser compatible. I propose to add the JS library from http://cross-browser.com/ to Moodle. Every developer can then work with this centralized library for cross browser DOM scripting without the need for different implementations of the same routines for every module. For the moving menu on my homepage http://unodo.de I used this scripts.

          The workaround for the moment is to define elements static to give them a fixed position on the screen. FF does and IE does not accept fixed. IE still uses the JS.

          For the timer three DIVs would be adequate. There is no need for that many tables with hardcoded style and layout. Gustav, will you rework the timer or shall I investigate?

          From Gustav Delius (gwd2 at york.ac.uk) Wednesday, 21 September 2005, 10:55 PM:

          Thank you Urs! Unfortunately I am horribly overloaded with work at the moment, so any improvement that you can make to the quiz module code will be very welcome.

          From Martin Dougiamas (martin at moodle.com) Thursday, 27 October 2005, 02:58 PM:

          Hi, Urs, is this fixed in 1.5 and 1.6? If so we can close this bug.

          From Urs Hunkler (u.hunkler at elearningkontor.de) Monday, 31 October 2005, 04:30 PM:

          I changed the timer once more to make it work the same in FF, MSIE, Opera and Safari. Because there were no complaints I close the bug.

          Show
          dougiamas Martin Dougiamas added a comment - From Gustav Delius (gwd2 at york.ac.uk) Friday, 16 September 2005, 04:01 PM: It is still working in IE. I have looked at the timer code and can't see anything wrong there (and there hasn't been much change since 1.4). Someone with more knowledge of dynamic positioning and firefox has to take a look at this. From Gustav Delius (gwd2 at york.ac.uk) Friday, 16 September 2005, 04:34 PM: I assume this is because absolute positioning (which is used to position the timer div) is not really absolute but relative to the parent element. Now that the page structure has become more complex, perhaps firefox has a different idea of what the parent element is from IE. Anyway, this is too complicated for me. From Martin Dougiamas (martin at moodle.com) Friday, 16 September 2005, 04:43 PM: aaaaaahh, thanks! cc'ing Urs From Urs Hunkler (u.hunkler at elearningkontor.de) Wednesday, 21 September 2005, 10:43 PM: I looked at the involved php and JavaScript and CSS. For a preliminarily fix to make the floating timer work in FF I committed additional properties in styles.php. The JavaScript handling the timer does not work in FF, it is not cross browser compatible. I propose to add the JS library from http://cross-browser.com/ to Moodle. Every developer can then work with this centralized library for cross browser DOM scripting without the need for different implementations of the same routines for every module. For the moving menu on my homepage http://unodo.de I used this scripts. The workaround for the moment is to define elements static to give them a fixed position on the screen. FF does and IE does not accept fixed. IE still uses the JS. For the timer three DIVs would be adequate. There is no need for that many tables with hardcoded style and layout. Gustav, will you rework the timer or shall I investigate? From Gustav Delius (gwd2 at york.ac.uk) Wednesday, 21 September 2005, 10:55 PM: Thank you Urs! Unfortunately I am horribly overloaded with work at the moment, so any improvement that you can make to the quiz module code will be very welcome. From Martin Dougiamas (martin at moodle.com) Thursday, 27 October 2005, 02:58 PM: Hi, Urs, is this fixed in 1.5 and 1.6? If so we can close this bug. From Urs Hunkler (u.hunkler at elearningkontor.de) Monday, 31 October 2005, 04:30 PM: I changed the timer once more to make it work the same in FF, MSIE, Opera and Safari. Because there were no complaints I close the bug.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: