Moodle
  1. Moodle
  2. MDL-40550

Make it clearer if badges will be issued immediately on activation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.2
    • Fix Version/s: 2.5.3, 2.6
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      Before testing, make sure badges are enabled.

      1. As admin create a badge.
      2. Don't add any criteria.
      3. Go to "Manage badges" page. Enable/disable icons should not be available among action icons.
      4. Go to badge editing pages and add some criteria.
      5. Return to "Manage badges" page. Enable/disable icons should now be among action icons.
      6. Try to enable access to the badge clicking on "Enable access" icon. You should be redirected to confirmation message "This will make your badge visible to users..." warning that this badge can be immediately issued to users who meet criteria.
      7. Click "Continue". You should be redirected to the "Manage badges" page. If action was successful, access to the badge should be enabled.
      8. Go to any of the badge editing pages.
      9. Click "Disable access" button in the badge status box area. Badge access should be disabled without warning and badge status should change to "This badge is currently not available to users... ".
      10. Click "Enable access" from any of the editing pages. You should be redirected to the confirmation message "This will make your badge visible to users..." (the same as earlier when you tried to enable badge access).
      11. Click "Continue". You should be redirected back to badge editing page (where you were before). If action was successful, access to the badge should be enabled.

      Show
      Before testing, make sure badges are enabled. 1. As admin create a badge. 2. Don't add any criteria. 3. Go to "Manage badges" page. Enable/disable icons should not be available among action icons. 4. Go to badge editing pages and add some criteria. 5. Return to "Manage badges" page. Enable/disable icons should now be among action icons. 6. Try to enable access to the badge clicking on "Enable access" icon. You should be redirected to confirmation message "This will make your badge visible to users..." warning that this badge can be immediately issued to users who meet criteria. 7. Click "Continue". You should be redirected to the "Manage badges" page. If action was successful, access to the badge should be enabled. 8. Go to any of the badge editing pages. 9. Click "Disable access" button in the badge status box area. Badge access should be disabled without warning and badge status should change to "This badge is currently not available to users... ". 10. Click "Enable access" from any of the editing pages. You should be redirected to the confirmation message "This will make your badge visible to users..." (the same as earlier when you tried to enable badge access). 11. Click "Continue". You should be redirected back to badge editing page (where you were before). If action was successful, access to the badge should be enabled.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40550_master

      Description

      When a badge is enabled it might get immediately issued to users who already meet the criteria.

      I think we need to make it clearer to users that this is going to happen (and that this will mean many of the badge settings will be locked).

      This screencast shows the issue:

      http://www.youtube.com/watch?v=FX_ggTZjn8I

      (interesting bit starts 10:50).

      You can see that as soon as the badge is enabled it is issued to 13 people, which locks it preventing the changes that she intended to make.

      I think that the confirmation page should say:

      This will make your badge visible to users and allow them to start earning it.

      Note: 24 users currently meet this badge's criteria and will be issued this badge immediately if you enable it now.

      Once a badge has been issued it will be locked - certain settings including the criteria and expiry settings can no longer be changed.

      Are you sure you want to enable the badge 'Badge Name'?

      The line in bold will only appear if 1 or more users will immediately receive the badge upon activation.

        Gliffy Diagrams

          Activity

          Hide
          Yuliya Bozhko added a comment -

          At the moment, this solution doesn't calculate how many users will get the badge. Activation message definitely needs to be improved though. I changed it according to suggestion.

          Also I noticed that activating badges from manage badges page doesn't generate activation message which is not consistent with activation from badge overview page. I updated this to get user confirmation of badge activation.

          Show
          Yuliya Bozhko added a comment - At the moment, this solution doesn't calculate how many users will get the badge. Activation message definitely needs to be improved though. I changed it according to suggestion. Also I noticed that activating badges from manage badges page doesn't generate activation message which is not consistent with activation from badge overview page. I updated this to get user confirmation of badge activation.
          Hide
          Dan Poltawski added a comment -

          Hi Yuliya,

          Looks good to me.

          I would split your commit message into multiple lines as the first line will be too long (short first line, space and then longer 'body text').

          +1 for integration

          Show
          Dan Poltawski added a comment - Hi Yuliya, Looks good to me. I would split your commit message into multiple lines as the first line will be too long (short first line, space and then longer 'body text'). +1 for integration
          Hide
          Yuliya Bozhko added a comment -

          Sure. Thanks, Dan! Will do that and submit for integration.

          Show
          Yuliya Bozhko added a comment - Sure. Thanks, Dan! Will do that and submit for integration.
          Hide
          Yuliya Bozhko added a comment -

          Rebased and split commit message.

          Show
          Yuliya Bozhko added a comment - Rebased and split commit message.
          Hide
          Marina Glancy added a comment -

          Thanks Yuliya, it has been integrated in 2.5 and master

          Show
          Marina Glancy added a comment - Thanks Yuliya, it has been integrated in 2.5 and master
          Hide
          Andrew Nicols added a comment -

          Passing this test with some notes.

          These items aren't as a result of this issue, but should probably be addressed - I'll leave them to you to raise as I could be wrong on some of them:

          • the help text does not marry up with the help text in the status box on the overview page; and
          • the colour change (from green to amber) is very subtle and unsuitable for users who are partially colour blind. I don't believe that this is an AA issue though because the text does inform the user, and the colour is only an added indicator and not required (hence not failing the issue);

          I also notice that the help tooltip is being a bit funky, but I'll raise a separate issue for this:

          • help text overflow not working so it escapes the bound of the help window; and
          • one of the tabs shows through.
          Show
          Andrew Nicols added a comment - Passing this test with some notes. These items aren't as a result of this issue, but should probably be addressed - I'll leave them to you to raise as I could be wrong on some of them: the help text does not marry up with the help text in the status box on the overview page; and the colour change (from green to amber) is very subtle and unsuitable for users who are partially colour blind. I don't believe that this is an AA issue though because the text does inform the user, and the colour is only an added indicator and not required (hence not failing the issue); I also notice that the help tooltip is being a bit funky, but I'll raise a separate issue for this: help text overflow not working so it escapes the bound of the help window; and one of the tabs shows through.
          Hide
          Yuliya Bozhko added a comment -

          Thanks, Andrew!

          I will have a look at those issues when I have a bit more time.

          Show
          Yuliya Bozhko added a comment - Thanks, Andrew! I will have a look at those issues when I have a bit more time.
          Hide
          Marina Glancy added a comment -

          And THANK YOU again for making Moodle better every day!

          Another weekly release has been released.

          Show
          Marina Glancy added a comment - And THANK YOU again for making Moodle better every day! Another weekly release has been released.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: