Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40569

it seems that CSS minifier sometimes returns empty result without any exception or status error

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 2.4.6, 2.5.2, 2.6
    • 2.6
    • Themes
    • MOODLE_26_STABLE
    • MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • w29_MDL-40569_m26_nocss
    • Hide

      0/ make sure css is served from one huge theme/style.php (may be chunked in IE)
      1/ install moodle
      2/ upgrade moodle
      3/ purge caches a few times
      4/ manually delete contents of datartoot/cache/theme directory and refresh browser

      There CSS should not disappear any more in any of these cases...

      Show
      0/ make sure css is served from one huge theme/style.php (may be chunked in IE) 1/ install moodle 2/ upgrade moodle 3/ purge caches a few times 4/ manually delete contents of datartoot/cache/theme directory and refresh browser There CSS should not disappear any more in any of these cases...

    Description

      I have discovered that sometimes the all.css cache file is empty - delete dataroot/cache/theme and reload browser (themedesigner off, css optimiser off - tested with PHP 5.5.0 and 5.4.x).

      After some poking I have discovered that the css_minify_css() sometimes returns empty string...

      We should aslo probably first process the CSS palceholders and only afterwards do the minimisation.

      maybe we could also append some testing CSS file with special rule marker and verify it is in the result too.

      Attachments

        Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40889 apply 304 minifier fix to js too

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40789 Prevent Minify from caching things (even more)

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-40563 cleanup, fix and improve theme resource caching

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              skodak Petr Skoda
              skodak Petr Skoda
              Damyon Wiese Damyon Wiese
              Dan Poltawski Dan Poltawski
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13