Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40569

it seems that CSS minifier sometimes returns empty result without any exception or status error

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.4.6, 2.5.2, 2.6
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      0/ make sure css is served from one huge theme/style.php (may be chunked in IE)
      1/ install moodle
      2/ upgrade moodle
      3/ purge caches a few times
      4/ manually delete contents of datartoot/cache/theme directory and refresh browser

      There CSS should not disappear any more in any of these cases...

      Show
      0/ make sure css is served from one huge theme/style.php (may be chunked in IE) 1/ install moodle 2/ upgrade moodle 3/ purge caches a few times 4/ manually delete contents of datartoot/cache/theme directory and refresh browser There CSS should not disappear any more in any of these cases...
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w29_MDL-40569_m26_nocss

      Description

      I have discovered that sometimes the all.css cache file is empty - delete dataroot/cache/theme and reload browser (themedesigner off, css optimiser off - tested with PHP 5.5.0 and 5.4.x).

      After some poking I have discovered that the css_minify_css() sometimes returns empty string...

      We should aslo probably first process the CSS palceholders and only afterwards do the minimisation.

      maybe we could also append some testing CSS file with special rule marker and verify it is in the result too.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Sep/13