Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40585

grouped_parser_processor::grouped_parent_exists needs a cache, it can get 10,000,000 for 500 paths on restore

    XMLWordPrintable

Details

    Description

      Restoring large numbers of questions in a restore results in the grouped_parser_processor::grouped_parent_exists getting called many millions of times. However due to the XML structure there are only a few parent paths to the top of the XML tree.

      Removing the calls to progressive_parser::dirname($parentpath) and being able to complete simple cache lookups will reduce restore times significantly.

      Attachments

        Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-41674 grouped_parser_processor::grouped_parent_exists is called too much

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-2343 Cannot upload some attachments to the tracker

          • Medium -
          • Closed

          Activity

            People

              mr-russ Russell Smith
              mr-russ Russell Smith
              Tim Hunt Tim Hunt
              Dan Poltawski Dan Poltawski
              Rossiani Wijaya Rossiani Wijaya
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13