[MDL-40585] grouped_parser_processor::grouped_parent_exists needs a cache, it can get 10,000,000 for 500 paths on restore - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.4.5, 2.5
Fix Version/s: 2.3.9, 2.4.6, 2.5.2
Component/s: Backup, Performance
Labels:
- triaged

Testing Instructions:

Hide

Restore a complex backup and ensure it restored correctly.

Show
Restore a complex backup and ensure it restored correctly.
Affected Branches:
MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Epic Link:
Restore performance
Pull from Repository:
git://github.com/mr-russ/moodle.git
Pull Master Branch:
~~MDL-40585~~_grouped_parent_exists
Pull Master Diff URL:
https://github.com/mr-russ/moodle/compare/master...MDL-40585_grouped_parent_exists

Description

Restoring large numbers of questions in a restore results in the grouped_parser_processor::grouped_parent_exists getting called many millions of times. However due to the XML structure there are only a few parent paths to the top of the XML tree.

Removing the calls to progressive_parser::dirname($parentpath) and being able to complete simple cache lookups will reduce restore times significantly.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-40585_precheck_after.mpr
142 kB
18/Jul/13 5:30 PM
MDL-40585_precheck_baseline.mpr
141 kB
13/Jul/13 12:23 PM

Issue Links

has been marked as being related by

MDL-41674 grouped_parser_processor::grouped_parent_exists is called too much

Closed

is blocked by

MDLSITE-2343 Cannot upload some attachments to the tracker

Closed

Activity

People

Assignee:: Russell Smith

Reporter:: Russell Smith

Peer reviewer:: Tim Hunt

Integrator:: Dan Poltawski

Tester:: Rossiani Wijaya

Participants:: Damyon Wiese, Dan Poltawski, Rossiani Wijaya, Russell Smith, Sam Marshall, Tim Hunt

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 09/Jul/13 5:45 PM

Updated:: 09/Sep/13 9:18 PM

Resolved:: 26/Jul/13 1:02 PM

Fix Release Date:: 9/Sep/13