Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40585

grouped_parser_processor::grouped_parent_exists needs a cache, it can get 10,000,000 for 500 paths on restore

    XMLWordPrintable

Details

    Description

      Restoring large numbers of questions in a restore results in the grouped_parser_processor::grouped_parent_exists getting called many millions of times. However due to the XML structure there are only a few parent paths to the top of the XML tree.

      Removing the calls to progressive_parser::dirname($parentpath) and being able to complete simple cache lookups will reduce restore times significantly.

      Attachments

        1. MDL-40585_precheck_after.mpr
          142 kB
          Russell Smith
        2. MDL-40585_precheck_baseline.mpr
          141 kB
          Russell Smith

        Issue Links

          Activity

            People

              mr-russ Russell Smith
              mr-russ Russell Smith
              Tim Hunt Tim Hunt
              Dan Poltawski Dan Poltawski
              Rossiani Wijaya Rossiani Wijaya
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13