Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34434 META: Collect together deprecated code changes for Moodle 2.6
  3. MDL-40604

Add proper deprecation debugging to ye olde deprecations

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.6
    • 2.6
    • Libraries
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • MDL-40604-master
    • Hide
      1. Add a wiki activity to course
      2. Add a few revisions to a page
      3. Click on history and then the version number on one of those older versions.
      4. VERIFY no debugging notices thrown
      5. Click on 'restore vthis verison'
      6. VERIFY: no debugging notices thrown
      7. Add a comment to the page
      8. Click the delete
      9. VERIFY: on the confirmation page no debugging notices are

      Git grep for the following functions and ensure there are no uses:
      filter_text
      httpsrequired
      detect_munged_arguments
      get_course_participants
      is_course_participant
      mygroupid
      current_theme
      skip_main_destination
      print_container
      print_container_start
      print_container_end
      print_continue
      print_header
      print_header_simple
      print_side_block
      print_arrow
      print_scale_menu_helpbutton
      print_checkbox
      print_navigation
      build_navigation
      navmenu
      add_event
      update_event
      delete_event
      hide_event
      show_event

      Show
      Add a wiki activity to course Add a few revisions to a page Click on history and then the version number on one of those older versions. VERIFY no debugging notices thrown Click on 'restore vthis verison' VERIFY: no debugging notices thrown Add a comment to the page Click the delete VERIFY: on the confirmation page no debugging notices are Git grep for the following functions and ensure there are no uses: filter_text httpsrequired detect_munged_arguments get_course_participants is_course_participant mygroupid current_theme skip_main_destination print_container print_container_start print_container_end print_continue print_header print_header_simple print_side_block print_arrow print_scale_menu_helpbutton print_checkbox print_navigation build_navigation navmenu add_event update_event delete_event hide_event show_event
    • BACKEND Sprint 2

    Description

      There are a lot of deprecatedlib.php depreactions which should be throwing debugging notices.

      This issue is to do that, so we can remove them in a few releases time.

      Attachments

        Issue Links

          blocks

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40424 Deprecate context_instance_preload_sql()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40468 Deprecate get_related_contexts_string()

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40721 Missing call to PAGE->set_url() after restoring a wiki page revision

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40701 Database error when doing course reset in mod_assignment

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-40463 Deprecate get_courseid_from_context()

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              poltawski Dan Poltawski
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              David Monllaó David Monllaó
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13