Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40621

TinyMCE plugins api little fix

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: HTML Editor (TinyMCE)
    • Labels:
      None
    • Testing Instructions:
      Hide

      This function is not really often used so the test is quite made up:

      1. Disable setting requiretex (or enable Tex filter)
      2. Open any page with html editor and make sure the button "Insert equation" appears in the 3rd row before the nonbreaking button.
      3. Modify TinyMCE settings and merge together 2nd and 3rd row of buttons
      4. Open any page with html editor and make sure the button "Insert equation" appears in the 2rd row before the nonbreaking button.
      Show
      This function is not really often used so the test is quite made up: Disable setting requiretex (or enable Tex filter) Open any page with html editor and make sure the button "Insert equation" appears in the 3rd row before the nonbreaking button. Modify TinyMCE settings and merge together 2nd and 3rd row of buttons Open any page with html editor and make sure the button "Insert equation" appears in the 2rd row before the nonbreaking button.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-40621-master
    • Pull Master Diff URL:

      Description

      While testing/debugging MDL-37565 I found a small bug in class editor_tinymce_plugin and couple of copy-pasted comments. Now when we develop more and more TinyMCE plugins this may appear more often.

      Problem: editor_tinymce_plugin::fix_row() always return 1 when specified row is not found. Presumably it was supposed to return the maximum available row number if specified row was too big.

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-37565 Better looking tinymce editor: toggle toolbars between 1 and 3 lines

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Petr Skoda
              Integrator:
              Damyon Wiese
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13