Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40626

disabled ajax and 'quick feedback' in grader report causes grades to become 'overridden' with multiline module feedback

    Details

    • Testing Instructions:
      Hide
      1. Have a course with multiple students enrolled, and a few offline assignments
      2. Grade some student submissions with multiline feedback.
      3. In the grader report settings, turn AJAX off (grade_report_enableajax) and Quick Feedback on (grade_report_showquickfeedback). (This means you should see feedback boxes too)
      4. In the grader report, turn editing on. Hit save down at the bottom.
      5. Confirm that non of the cells have turned colors to indicate overridden.
      Show
      Have a course with multiple students enrolled, and a few offline assignments Grade some student submissions with multiline feedback. In the grader report settings, turn AJAX off (grade_report_enableajax) and Quick Feedback on (grade_report_showquickfeedback). (This means you should see feedback boxes too) In the grader report, turn editing on. Hit save down at the bottom. Confirm that non of the cells have turned colors to indicate overridden.
    • Workaround:
      Hide

      Disable Quick Grading

      Show
      Disable Quick Grading
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-40626-master

      Description

      This is another fix raised in https://tracker.moodle.org/browse/MDL-34363.

      When you are in the viewing the gradebook in 'grader report' and have 'show quick feedback' enabled so you have the feedback box and disable 'Enable AJAX'.

      Then go into edit mode in the grader report and click 'update'. All fields with multiline feedback from a module like assign / assignment are now set to overridden.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for working on this, Tim.

              Show
              salvetore Michael de Raadt added a comment - Thanks for working on this, Tim.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Tim,

              Thanks for the patch! I've tested and verified your fix and it looks good for integration.

              Unfortunately your branch wasn't structured quite right (we need a single branch based off moodle.git with only the commits relevant to the issue) so I have taken the liberty of preparing your commit for integration in a branch.

              (You might find Tim Hunt's blogpost helpful for describing how we like the patches http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html)

              Show
              poltawski Dan Poltawski added a comment - Hi Tim, Thanks for the patch! I've tested and verified your fix and it looks good for integration. Unfortunately your branch wasn't structured quite right (we need a single branch based off moodle.git with only the commits relevant to the issue) so I have taken the liberty of preparing your commit for integration in a branch. (You might find Tim Hunt's blogpost helpful for describing how we like the patches http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html )
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated (24, 25 & master), thanks!

              Still the feedback quick box looks really awful in the grader report, but that's another story.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks! Still the feedback quick box looks really awful in the grader report, but that's another story.
              Hide
              dmonllao David Monllaó added a comment -

              It passes, tested in 24, 25 and master

              Show
              dmonllao David Monllaó added a comment - It passes, tested in 24, 25 and master
              Hide
              damyon Damyon Wiese added a comment -

              Thanks again for another week of fixes, improvements and testing. These changes have been released to the world.

              Cheers, Damyon

              Show
              damyon Damyon Wiese added a comment - Thanks again for another week of fixes, improvements and testing. These changes have been released to the world. Cheers, Damyon

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13