Moodle
  1. Moodle
  2. MDL-40626

disabled ajax and 'quick feedback' in grader report causes grades to become 'overridden' with multiline module feedback

    Details

    • Rank:
      51464

      Description

      This is another fix raised in https://tracker.moodle.org/browse/MDL-34363.

      When you are in the viewing the gradebook in 'grader report' and have 'show quick feedback' enabled so you have the feedback box and disable 'Enable AJAX'.

      Then go into edit mode in the grader report and click 'update'. All fields with multiline feedback from a module like assign / assignment are now set to overridden.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for working on this, Tim.

          Show
          Michael de Raadt added a comment - Thanks for working on this, Tim.
          Hide
          Dan Poltawski added a comment -

          Hi Tim,

          Thanks for the patch! I've tested and verified your fix and it looks good for integration.

          Unfortunately your branch wasn't structured quite right (we need a single branch based off moodle.git with only the commits relevant to the issue) so I have taken the liberty of preparing your commit for integration in a branch.

          (You might find Tim Hunt's blogpost helpful for describing how we like the patches http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html)

          Show
          Dan Poltawski added a comment - Hi Tim, Thanks for the patch! I've tested and verified your fix and it looks good for integration. Unfortunately your branch wasn't structured quite right (we need a single branch based off moodle.git with only the commits relevant to the issue) so I have taken the liberty of preparing your commit for integration in a branch. (You might find Tim Hunt's blogpost helpful for describing how we like the patches http://tjhunt.blogspot.com.au/2012/03/fixing-bug-in-moodle-core-mechanics.html )
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (24, 25 & master), thanks!

          Still the feedback quick box looks really awful in the grader report, but that's another story.

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (24, 25 & master), thanks! Still the feedback quick box looks really awful in the grader report, but that's another story.
          Hide
          David Monllaó added a comment -

          It passes, tested in 24, 25 and master

          Show
          David Monllaó added a comment - It passes, tested in 24, 25 and master
          Hide
          Damyon Wiese added a comment -

          Thanks again for another week of fixes, improvements and testing. These changes have been released to the world.

          Cheers, Damyon

          Show
          Damyon Wiese added a comment - Thanks again for another week of fixes, improvements and testing. These changes have been released to the world. Cheers, Damyon

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: