Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40628

show new available global settings after cli upgrade

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.4.5
    • Fix Version/s: None
    • Component/s: Installation
    • Labels:
      None
    • Testing Instructions:
      Hide

      test environment setup

      • edit a module to add new setting. E.g, duplicate an existing setting in mod_forum and add "_fake" behind setting name.

      diff --git a/mod/forum/settings.php b/mod/forum/settings.php
      index 6551c73b40..d36fd1b17c 100644
      --- a/mod/forum/settings.php
      +++ b/mod/forum/settings.php
      @@ -135,6 +135,9 @@ if ($ADMIN->fulltree) {
       }
      $settings->add(new admin_setting_configcheckbox('forum_enabletimedposts', get_string('timedposts', 'forum'),
       get_string('configenabletimedposts', 'forum'), 1));
      +
      + $settings->add(new admin_setting_configcheckbox('forum_enabletimedposts_fake', get_string('timedposts', 'forum'),
      + get_string('configenabletimedposts', 'forum'), 1));
       }
      

      * increment module version. E.g, in mod/forum/version.php

      • increment Moodle version in version.php

       

      result

      after setting up the environment, run command line

      php admin/cli/upgrade.php

      current result

      you don't have information that a new setting forum_enabletimedposts_fake is available

      expected result

      you have an information that the new setting forum_enabletimedposts_fake is available

       

      test scenario

      (for each cases, repeat environment setup)

      cli

      • try an upgrade without new settings (just change moodle version)
        • you should see this message : No new settings were added during this upgrade.
      • try an upgrade with 1 new setting in a module
        • you should see an information about your new setting
      • try an upgrade with 2 new settings in a module
        • you should see an information about your new settings
      • try an upgrade with 1 new setting in a module and 2 new settings in another module
        • you should see an separated information per module about your new settings

      gui

      • due to refactoring, check if there is no regression with graphic upgrade system. Information about new settings should be visible when needed.

       

      Show
      test environment setup edit a module to add new setting. E.g, duplicate an existing setting in mod_forum and add "_fake" behind setting name. diff --git a/mod/forum/settings.php b/mod/forum/settings.php index 6551c73b40..d36fd1b17c 100644 --- a/mod/forum/settings.php +++ b/mod/forum/settings.php @@ -135,6 +135,9 @@ if ($ADMIN->fulltree) { } $settings->add(new admin_setting_configcheckbox('forum_enabletimedposts', get_string('timedposts', 'forum'), get_string('configenabletimedposts', 'forum'), 1)); + + $settings->add(new admin_setting_configcheckbox('forum_enabletimedposts_fake', get_string('timedposts', 'forum'), + get_string('configenabletimedposts', 'forum'), 1)); } * increment module version. E.g, in mod/forum/version.php increment Moodle version in version.php   result after setting up the environment, run command line php admin/cli/upgrade.php current result you don't have information that a new setting forum_enabletimedposts_fake is available expected result you have an information that the new setting forum_enabletimedposts_fake is available   test s cenario (for each cases, repeat environment setup) cli try an upgrade without new settings (just change moodle version) you should see this message : No new settings were added during this upgrade. try an upgrade with 1 new setting in a module you should see an information about your new setting try an upgrade with 2 new settings in a module you should see an information about your new settings try an upgrade with 1 new setting in a module and 2 new settings in another module you should see an separated information per module about your new settings gui due to refactoring, check if there is no regression with graphic upgrade system. Information about new settings should be visible when needed.  
    • Affected Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-40628-cli-upgrade-settings

      Description

      After php admin/cli/upgrade.php command, it will be nice to see what are new admin variables on Moodle (especially on major version).

      Maybe there is a trick to see it on web interface, but I didn't find...

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jboulen Julien Boulen
              Reporter:
              jboulen Julien Boulen
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: