Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40633

Regression: auto-linking filter behaving badly

    XMLWordPrintable

Details

    • MOODLE_23_STABLE, MOODLE_25_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Hide

      The unit tests are sufficient.

      You may wish to revert the change to filter/urltolink/filter.php, run the unit tests, and verify that you get two failures that look like the problem reported in the forum, then re-apply the filter.php changes and verify that they fix the problem.

      Show
      The unit tests are sufficient. You may wish to revert the change to filter/urltolink/filter.php, run the unit tests, and verify that you get two failures that look like the problem reported in the forum, then re-apply the filter.php changes and verify that they fix the problem.

    Description

      Where previously images were being displayed, moodle now shows this in content:

      www.ahsgerman.com/vle/pluginfile.php?file=/110/mod_book/chapter/27/sophias%20pictures%201.jpg" alt="sophia 1" height="320" width="240" />
      		 
       
      		 
      www.ahsgerman.com/vle/pluginfile.php?file=/110/mod_book/chapter/27/sophias%20pictures%202.jpg" alt="sophia 2" style="border: 2px solid black;" height="320" width="240" />
      		 
       
      		 
      www.ahsgerman.com/vle/pluginfile.php?file=/110/mod_book/chapter/27/sophias%20pictures%203.jpg" alt="sophia 3" style="border: 2px solid black;" height="320" width="240" />
      		 
       
      		 
      www.ahsgerman.com/vle/pluginfile.php?file=/110/mod_book/chapter/27/sophias%20pictures%204.jpg" alt="sophia 4" style="border: 2px solid black;" height="240" width="320" />
      		 
       
      		 
      www.ahsgerman.com/vle/pluginfile.php?file=/110/mod_book/chapter/27/sophias%20pictures%205.jpg" alt="sophia 5" style="border: 2px solid black;" height="240" width="320" />

      reported in forums:
      https://moodle.org/mod/forum/discuss.php?d=231543
      https://moodle.org/mod/forum/discuss.php?d=232357

      seems to be due to the patch in MDL-22390

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40671 Auto-linking filter messing up course labels

          • Major - Major loss of function, incorrect output
          • Closed
          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-22390 Auto-linking does not like brackets.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40692 2.5.1+ Videos Embedded in Books Don't Work

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              timhunt Tim Hunt
              danmarsden Dan Marsden
              Marina Glancy Marina Glancy
              Rossiani Wijaya Rossiani Wijaya
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Sep/13