Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40667

New "Alternate name fields" functionality breaks localisation of display formats

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing

      1. Change the following strings in lang/en/admin.php to something different to what they are currently set.
        • $string['alternatename']
        • $string['firstname']
        • $string['firstnamephonetic']
        • $string['lastname']
        • $string['lastnamephonetic']
        • $string['middlename']
      2. Change the fullnamedisplay setting. Use the place-holders that you set in the language pack.
      3. Save the setting and then check out the entry in the database table mdl_config (name = fullnamedisplay). Make sure that they are saved as a combination of firstname, firstnamephonetic, lastname, lastnamephonetic, middlename, alternatename.
      4. Try a few different combinations and make sure that they are changed to the appropriate setting in the database.
      Show
      Testing Change the following strings in lang/en/admin.php to something different to what they are currently set. $string ['alternatename'] $string ['firstname'] $string ['firstnamephonetic'] $string ['lastname'] $string ['lastnamephonetic'] $string ['middlename'] Change the fullnamedisplay setting. Use the place-holders that you set in the language pack. Save the setting and then check out the entry in the database table mdl_config (name = fullnamedisplay). Make sure that they are saved as a combination of firstname, firstnamephonetic, lastname, lastnamephonetic, middlename, alternatename. Try a few different combinations and make sure that they are changed to the appropriate setting in the database.
    • Affected Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-40667-master-two

      Description

      With new "Alternate name fields" functionnality (as of Moodle 2.6dev, see MDL-31776), we lose the localisation of the display format of user names.

      With 2.5, we get a dropdown with several (fixed) formats, whose denomination was translatable.

      With this new functionality, we get placeholders which resembles normal strings and aren't translatable anymore. This regression causes usability problems and potentially bugs:

      • It is not obvious that you have to enter the placeholders as is: if someone makes typos, she'll have problems
      • Help strings mixes english (for hardcoded placeholders) and the language of the lang pack
      • Help strings will need update for any modification of the placeholders.

      Suggested improvement for MDL-31776:

      • make more visible that the placeholders are special strings
      • allow localisation of placeholders
      • use options for placeholders, instead of free text field. To be resolved: how to order the placeholders
      • use drag&drop list (YUI) for ordering chosen placeholders

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                8 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated: