Moodle
  1. Moodle
  2. MDL-40678

Split out moodle-core-notification

    Details

    • Testing Instructions:
      Hide

      You will need to use the Developer Tools for these tests, including:

      • Network tab
      • Scripts tab
      • Console tab

      For your own sanity, use Chrome, open the Network tab, and press escape.

      • Open the login page:
        • Confirm that there were no errors in the console
        • Confirm that moodle-core-notification was loaded
        • Confirm that moodle-core-notification's dependencies were loaded
      • Click on the help icon
        • Confirm that the help popup is displayed correctly
      • Login as a teacher
      • Navigation to a course page
      • Turn editing on
      • Open the Activity chooser
        • Confirm that it displayed as expected*

      Try a few other dialogues which extend moodle-core-dialogue.

      Show
      You will need to use the Developer Tools for these tests, including: Network tab Scripts tab Console tab For your own sanity, use Chrome, open the Network tab, and press escape. Open the login page: Confirm that there were no errors in the console Confirm that moodle-core-notification was loaded Confirm that moodle-core-notification's dependencies were loaded Click on the help icon Confirm that the help popup is displayed correctly Login as a teacher Navigation to a course page Turn editing on Open the Activity chooser Confirm that it displayed as expected* Try a few other dialogues which extend moodle-core-dialogue.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
    • Rank:
      51532

      Description

      Split out moodle-core-notification into smaller constituent submodules.
      This will have the effect of reducing the size of the components of moodle-core-notification that we need to frequently load. We often use dialogue but rarely use:

      • confirm
      • alert
      • exception
      • ajaxexception

      This will also allow us to more easily consolidate other dialogue types into the same module in a more appropriate fashion:

      • tooltip (used by popuphelp)
      • chooserdialogue (used by modchooser, and proposed qbankchooser and blockchooser)

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          Will write testing instructions in the morning.

          Show
          Andrew Nicols added a comment - Will write testing instructions in the morning.
          Hide
          Dan Poltawski added a comment -

          Hi Andrew,

          +1, looks good to me

          Show
          Dan Poltawski added a comment - Hi Andrew, +1, looks good to me
          Hide
          Sam Hemelryk added a comment -

          Yay - I was hoping to get this one

          Show
          Sam Hemelryk added a comment - Yay - I was hoping to get this one
          Hide
          Sam Hemelryk added a comment -

          Spot on thanks Andrew - nice split!

          Just noting I fixed a typo during integration.

          Show
          Sam Hemelryk added a comment - Spot on thanks Andrew - nice split! Just noting I fixed a typo during integration.
          Hide
          Jason Fowler added a comment -

          Thanks Andrew.

          "For your own sanity, use Chrome." is great advice under any situation

          Show
          Jason Fowler added a comment - Thanks Andrew. "For your own sanity, use Chrome." is great advice under any situation
          Hide
          Sam Hemelryk added a comment -

          Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!

          "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
          Adams, D (1992) Mostly Harmless. London: William Heinemann.

          Show
          Sam Hemelryk added a comment - Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you! "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office." Adams, D (1992) Mostly Harmless. London: William Heinemann.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: