Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40678

Split out moodle-core-notification

    XMLWordPrintable

Details

    • Task
    • Resolution: Fixed
    • Major
    • 2.6
    • 2.6
    • JavaScript
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • Hide

      You will need to use the Developer Tools for these tests, including:

      • Network tab
      • Scripts tab
      • Console tab

      For your own sanity, use Chrome, open the Network tab, and press escape.

      • Open the login page:
        • Confirm that there were no errors in the console
        • Confirm that moodle-core-notification was loaded
        • Confirm that moodle-core-notification's dependencies were loaded
      • Click on the help icon
        • Confirm that the help popup is displayed correctly
      • Login as a teacher
      • Navigation to a course page
      • Turn editing on
      • Open the Activity chooser
        • Confirm that it displayed as expected*

      Try a few other dialogues which extend moodle-core-dialogue.

      Show
      You will need to use the Developer Tools for these tests, including: Network tab Scripts tab Console tab For your own sanity, use Chrome, open the Network tab, and press escape. Open the login page: Confirm that there were no errors in the console Confirm that moodle-core-notification was loaded Confirm that moodle-core-notification's dependencies were loaded Click on the help icon Confirm that the help popup is displayed correctly Login as a teacher Navigation to a course page Turn editing on Open the Activity chooser Confirm that it displayed as expected* Try a few other dialogues which extend moodle-core-dialogue.

    Description

      Split out moodle-core-notification into smaller constituent submodules.
      This will have the effect of reducing the size of the components of moodle-core-notification that we need to frequently load. We often use dialogue but rarely use:

      • confirm
      • alert
      • exception
      • ajaxexception

      This will also allow us to more easily consolidate other dialogue types into the same module in a more appropriate fashion:

      • tooltip (used by popuphelp)
      • chooserdialogue (used by modchooser, and proposed qbankchooser and blockchooser)

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40800 Use moodle-core-notification more selectively

          • Minor - Minor loss of function where workaround is possible
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-42477 Hyperlinked glossary words do not show their definition in activities

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46525 JS error on enrolling students from cohort

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41364 Appalling apostrophe crime in moodle-core-notification

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40477 Convert YUI_config functions to a readable version

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-40478 Allow YUI modules to support loading of submodules

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Jason Fowler Jason Fowler
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13