Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40678

Split out moodle-core-notification

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      You will need to use the Developer Tools for these tests, including:

      • Network tab
      • Scripts tab
      • Console tab

      For your own sanity, use Chrome, open the Network tab, and press escape.

      • Open the login page:
        • Confirm that there were no errors in the console
        • Confirm that moodle-core-notification was loaded
        • Confirm that moodle-core-notification's dependencies were loaded
      • Click on the help icon
        • Confirm that the help popup is displayed correctly
      • Login as a teacher
      • Navigation to a course page
      • Turn editing on
      • Open the Activity chooser
        • Confirm that it displayed as expected*

      Try a few other dialogues which extend moodle-core-dialogue.

      Show
      You will need to use the Developer Tools for these tests, including: Network tab Scripts tab Console tab For your own sanity, use Chrome, open the Network tab, and press escape. Open the login page: Confirm that there were no errors in the console Confirm that moodle-core-notification was loaded Confirm that moodle-core-notification's dependencies were loaded Click on the help icon Confirm that the help popup is displayed correctly Login as a teacher Navigation to a course page Turn editing on Open the Activity chooser Confirm that it displayed as expected* Try a few other dialogues which extend moodle-core-dialogue.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      Split out moodle-core-notification into smaller constituent submodules.
      This will have the effect of reducing the size of the components of moodle-core-notification that we need to frequently load. We often use dialogue but rarely use:

      • confirm
      • alert
      • exception
      • ajaxexception

      This will also allow us to more easily consolidate other dialogue types into the same module in a more appropriate fashion:

      • tooltip (used by popuphelp)
      • chooserdialogue (used by modchooser, and proposed qbankchooser and blockchooser)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Dan Poltawski Dan Poltawski
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Jason Fowler Jason Fowler
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13