Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40678

Split out moodle-core-notification

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.6
    • 2.6
    • JavaScript
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE
    • Hide

      You will need to use the Developer Tools for these tests, including:

      • Network tab
      • Scripts tab
      • Console tab

      For your own sanity, use Chrome, open the Network tab, and press escape.

      • Open the login page:
        • Confirm that there were no errors in the console
        • Confirm that moodle-core-notification was loaded
        • Confirm that moodle-core-notification's dependencies were loaded
      • Click on the help icon
        • Confirm that the help popup is displayed correctly
      • Login as a teacher
      • Navigation to a course page
      • Turn editing on
      • Open the Activity chooser
        • Confirm that it displayed as expected*

      Try a few other dialogues which extend moodle-core-dialogue.

      Show
      You will need to use the Developer Tools for these tests, including: Network tab Scripts tab Console tab For your own sanity, use Chrome, open the Network tab, and press escape. Open the login page: Confirm that there were no errors in the console Confirm that moodle-core-notification was loaded Confirm that moodle-core-notification's dependencies were loaded Click on the help icon Confirm that the help popup is displayed correctly Login as a teacher Navigation to a course page Turn editing on Open the Activity chooser Confirm that it displayed as expected* Try a few other dialogues which extend moodle-core-dialogue.

    Description

      Split out moodle-core-notification into smaller constituent submodules.
      This will have the effect of reducing the size of the components of moodle-core-notification that we need to frequently load. We often use dialogue but rarely use:

      • confirm
      • alert
      • exception
      • ajaxexception

      This will also allow us to more easily consolidate other dialogue types into the same module in a more appropriate fashion:

      • tooltip (used by popuphelp)
      • chooserdialogue (used by modchooser, and proposed qbankchooser and blockchooser)

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Jason Fowler Jason Fowler
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13