Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40680

store_memcached have wrong param type and lang string for Memcached::SERIALIZER_IGBINARY]

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.5, 2.5.1
    • Fix Version/s: 2.4.6, 2.5.2
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      Prequesistes:

      You need the memcached extension installed, compiled with the igbinary option. (If you don't have this, discuss with Dan, don't waste a load of time configuing it)
      You should run the memcached server for testing.
      You should have the performance footer enabled in your moodle showing cache hits/misses etc.

      1. Go to Home /  ▶ Site administration /  ▶ Plugins /  ▶ Caching /  ▶ Configuration
      2. In *Memcached* click on 'add an instance'
      3. Give it a name, set your memcached server (127.0.0.1) leave all other options as default
      4. Edit the memcached store you just created
      5. Change the serialiser to 'the igbinary serialiser' and save store
      6. Go back to the edit page of that store
      7. VERIFY: the igbinary serialiser is selected
      8. Change to the default php serialiser and save
      9. Go back to the edit page of that store
      10. VERIFY: the default serialiser option is selected
      11. Go back to the cache config page
      12. Click 'edit mapping' on Language string cache
      13. Change the primary store to your memcached store
      14. Browse around Moodle a bit
      15. VERFIY: you see some hits in the cachestore_memcached under the core/string cache in the performance footer.
      Show
      Prequesistes: You need the memcached extension installed, compiled with the igbinary option. (If you don't have this, discuss with Dan, don't waste a load of time configuing it) You should run the memcached server for testing. You should have the performance footer enabled in your moodle showing cache hits/misses etc. Go to Home /  ▶ Site administration /  ▶ Plugins /  ▶ Caching /  ▶ Configuration In * Memcached * click on 'add an instance' Give it a name, set your memcached server (127.0.0.1) leave all other options as default Edit the memcached store you just created Change the serialiser to 'the igbinary serialiser' and save store Go back to the edit page of that store VERIFY: the igbinary serialiser is selected Change to the default php serialiser and save Go back to the edit page of that store VERIFY: the default serialiser option is selected Go back to the cache config page Click 'edit mapping' on Language string cache Change the primary store to your memcached store Browse around Moodle a bit VERFIY: you see some hits in the cachestore_memcached under the core/string cache in the performance footer.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40680-master
    • Sprint:
      BACKEND Sprint 2

      Description

      Originally discovered while investigating incorrect uses of PARAM_NUMBER. The serialiser option uses PARAM_NUMBER and the form actually wants ints like Memcached::SERIALIZER_IGBINARY.

      cache/stores/memcached/addinstanceform.php:        $form->setType('serialiser', PARAM_NUMBER);
      

      But I also discovered that the Memcached::SERIALIZER_IGBINARY has the wrong lang string too.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  poltawski Dan Poltawski
                  Reporter:
                  poltawski Dan Poltawski
                  Peer reviewer:
                  Frédéric Massart
                  Integrator:
                  Sam Hemelryk
                  Tester:
                  Sam Hemelryk
                  Participants:
                  Component watchers:
                  Matteo Scaramuccia, Ankit Agarwal, David Monllaó
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13