Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40693

Make Bootstrapbase breadcrumb seperator respect $THEME->rarrow

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5, 2.5.4, 2.6.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: HTML and CSS, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Change to the clean theme.
      3. Browse to a course
      4. Observe that ► is used to separate navbar items.
      5. Change to a RTL lang and ensure the separator is now ◄
      6. Edit the theme/clean/config.php and set the $THEME->rarrow = '/' and $THEME->larrow = '\';
      7. Retest the above and check you get / and \ as your separators now.
      Show
      Log in as admin Change to the clean theme. Browse to a course Observe that ► is used to separate navbar items. Change to a RTL lang and ensure the separator is now ◄ Edit the theme/clean/config.php and set the $THEME->rarrow = '/' and $THEME->larrow = '\'; Retest the above and check you get / and \ as your separators now.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      40693-27
    • Pull Master Diff URL:
    • Story Points:
      3
    • Sprint:
      FRONTEND Sprint 8

      Description

      The breadcrumb seperator "/" is hardcoded in a renderer for the Bootstrapbase/Clean themes, here:

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/renderers/core_renderer.php#L61

      It should probably get the character from $THEME->rarrow so that child themes have an easy way to change this character.

      (A better way to fix this is to do it all in CSS, like Bootstrap v3 or the Pure YUI framework, but the actual character is used in Bootstrap 2.3 for IE7 compatability and it's what Moodle themers are used to).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14