Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40721

Missing call to PAGE->set_url() after restoring a wiki page revision

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.5
    • 2.5.6, 2.6.3
    • Wiki (2.x)

    Description

      The debugging message is displayed when restoring a wiki page's version following the revision number; after confirming the restore, in the redirection page it appears the following message.

      For what Dan commented in https://tracker.moodle.org/browse/MDL-40604?focusedCommentId=233711&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-233711 is only using Clean theme.

      I reproduced the same problem in 25 and master.

      This page did not call $PAGE->set_url(...). Using http://localhost/INTEGRATION/master/mod/wiki/restoreversion.php?confirm=1&pageid=1&versionid=3&sesskey=3Dgb9dLngG
      line 558 of /lib/pagelib.php: call to debugging()
      line 734 of /lib/pagelib.php: call to moodle_page->magic_get_url()
      line 496 of /mod/wiki/lib.php: call to moodle_page->__get()
      line 2041 of /lib/navigationlib.php: call to wiki_extend_navigation()
      line 1205 of /lib/navigationlib.php: call to global_navigation->load_activity()
      line 222 of /blocks/navigation/block_navigation.php: call to global_navigation->initialise()
      line 178 of /blocks/navigation/block_navigation.php: call to block_navigation->get_navigation()
      line 296 of /blocks/moodleblock.class.php: call to block_navigation->get_content()
      line 238 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
      line 956 of /lib/blocklib.php: call to block_base->get_content_for_output()
      line 1008 of /lib/blocklib.php: call to block_manager->create_block_contents()
      line 353 of /lib/blocklib.php: call to block_manager->ensure_content_created()
      line 3074 of /lib/outputrenderers.php: call to block_manager->region_has_content()
      line 3110 of /lib/outputrenderers.php: call to core_renderer->body_css_classes()
      line 26 of /theme/clean/layout/embedded.php: call to core_renderer->body_attributes()
      line 847 of /lib/outputrenderers.php: call to include()
      line 777 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
      line 720 of /lib/outputrenderers.php: call to core_renderer->header()
      line 2567 of /lib/weblib.php: call to core_renderer->redirect_message()
      line 2155 of /mod/wiki/pagelib.php: call to redirect()
      line 81 of /mod/wiki/restoreversion.php: call to page_wiki_confirmrestore->print_content()
      id="page-mod-wiki-restoreversion" class="format-weeks path-mod path-mod-wiki safari dir-ltr lang-en yui-skin-sam yui3-skin-sam localhost--INTEGRATION-master pagelayout-redirect course-3 context-39 cmid-12 category-1 editing has-region-side-pre used-region-side-pre has-region-side-post empty-region-side-post">
      

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              dmonllao David Monllaó
              Sam Hemelryk Sam Hemelryk
              David Monllaó David Monllaó
              Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14