Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40741

Adapt behat tests to clean theme

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Check that CI jobs are passing (ask integrators if you don't have access)

      Test 2

      1. Add $CFG->theme = 'clean'; to your config.php
      2. php admin/tool/behat/cli/util.php update
      3. Run the whole behat suite
      4. You SHOULD only see failures related with docking blocks (MDL-38923)
      Show
      Test 1 Check that CI jobs are passing (ask integrators if you don't have access) Test 2 Add $CFG->theme = 'clean'; to your config.php php admin/tool/behat/cli/util.php update Run the whole behat suite You SHOULD only see failures related with docking blocks ( MDL-38923 )
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40741_master

      Description

      Once clean theme becomes the default one, the test suite will begin using it; before integrating it (2.5 release) I ran the whole suite using it and there were a couple of errors regarding block docking and another one that I don't remember.

      Before clean becomes the default theme in master this issue should be done, and, depending on the changes it requires integrated before or at the same time than the issue that makes clean the default theme.

      There will be cases where we will have to choose to change a xpath to bootstrap CSS selectors or maintain compatibility with both; as long as the compatibility with both themes does not imply a significant performance loose I would keep compatibility with both themes inherited from standard and bootstrap for a couple of major releases, so we can run the suite in different themes if we are interested on it.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/Jan/14