Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40746

Feedback forms display oddly in Clean theme

    Details

    • Testing Instructions:
      Hide

      To test it the feedback module must be activated

      1. Purge the moodle cache and the browser cache too.
      2. Ensure you are using the 'clean' theme.
      3. Create a new feedback instance.
      4. Within the feedback activity, create items of each multiple choice question type.
      5. The items should now displayed in the right way.
      Show
      To test it the feedback module must be activated Purge the moodle cache and the browser cache too. Ensure you are using the 'clean' theme. Create a new feedback instance. Within the feedback activity, create items of each multiple choice question type. The items should now displayed in the right way.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-40746_master

      Description

      The forms in in the Feedback activity display oddly due to clashes between Bootstrap's CSS for form items and the current HTML/CSS.

      A short-term fix would (probably) be to set the label tags in this area to display: inline-block, rather than the Bootstrap default of display: block as this has been a common issue in other areas.

      Longer term the harmonisation of the 20+ different form layouts methods used in Moodle so that they call a single renderer is the real solution.

        Gliffy Diagrams

          Activity

          Hide
          grabs Andreas Grabs added a comment -

          Hi,
          I changed the css in the feedback module.
          Best regards
          Andreas

          Show
          grabs Andreas Grabs added a comment - Hi, I changed the css in the feedback module. Best regards Andreas
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Hi David, have you had a look at this and are you happy with it?

          Show
          samhemelryk Sam Hemelryk added a comment - Hi David, have you had a look at this and are you happy with it?
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Andreas - I've integrated this now David if you have any objections let me know and we'll find a road through.

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Andreas - I've integrated this now David if you have any objections let me know and we'll find a road through.
          Hide
          markn Mark Nelson added a comment -

          I found the last step kind of ambigious. I am not sure what the 'right way' is, and what page I am supposed to be looking at but it did seem to render fine from what I could tell. I attached screenshots to confirm, if they do not look right please let me know.

          Show
          markn Mark Nelson added a comment - I found the last step kind of ambigious. I am not sure what the 'right way' is, and what page I am supposed to be looking at but it did seem to render fine from what I could tell. I attached screenshots to confirm, if they do not look right please let me know.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!

          "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
          Adams, D (1992) Mostly Harmless. London: William Heinemann.

          Show
          samhemelryk Sam Hemelryk added a comment - Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you! "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office." Adams, D (1992) Mostly Harmless. London: William Heinemann.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Sep/13