Moodle
  1. Moodle
  2. MDL-40775

Undefined variable $type in feedback activity

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.4.5, 2.5.1
        • Fix Version/s: 2.4.6, 2.5.2
        • Component/s: Feedback
        • Labels:
        • Testing Instructions:
          Hide

          To test it the feedback module must be activated

          1. create a new feedback instance
          2. within the feedback activity, select 'templates' tab
          3. select 'import questions' link
          Show
          To test it the feedback module must be activated create a new feedback instance within the feedback activity, select 'templates' tab select 'import questions' link
        • Affected Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE
        • Fixed Branches:
          MOODLE_24_STABLE, MOODLE_25_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-40775_master
        • Pull Master Diff URL:

          Description

          Found the following notice:

          stable/master/lib/pear/HTML/QuickForm/group.php on line 277

          Reproduction steps:

          1. within the feedback activity, select 'templates' tab
          2. select 'import questions' link
            Undefined variable $type occured.

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Andreas Grabs added a comment -

              Hi Rossiani,
              thank you for reporting!
              There were two unused lines inside the import_form. The last was causing the notice message.
              I have removed both now.
              Best regards
              Andreas

              Show
              Andreas Grabs added a comment - Hi Rossiani, thank you for reporting! There were two unused lines inside the import_form. The last was causing the notice message. I have removed both now. Best regards Andreas
              Hide
              Permalink
              Dan Poltawski added a comment -

              Thanks Andreas, I've integrated this to master, 25 and 24.

              I've also added a commit on 2.5+ to remove the uncessary header section (which results in a blank dropdown with collapsed forms)

              Show
              Dan Poltawski added a comment - Thanks Andreas, I've integrated this to master, 25 and 24. I've also added a commit on 2.5+ to remove the uncessary header section (which results in a blank dropdown with collapsed forms)
              Hide
              Permalink
              Mark Nelson added a comment -

              Didn't get a notice about an undefined variable, passing. Thanks Andreas.

              Show
              Mark Nelson added a comment - Didn't get a notice about an undefined variable, passing. Thanks Andreas.
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!

              "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
              Adams, D (1992) Mostly Harmless. London: William Heinemann.

              Show
              Sam Hemelryk added a comment - Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you! "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office." Adams, D (1992) Mostly Harmless. London: William Heinemann.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: