Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40793

Allow profiling comparisons with more than one previous run

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5.2
    • Component/s: Performance
    • Labels:
    • Testing Instructions:
      Hide

      PREREQUSITES:

      1. You need the xhprof extension installed.

      Login as Admin

      Administration > Site Administration > Development > Profiling

      • Enable Profiling
      • Profile these should be * for all.
      • Save changes

      Administration > Site Administration > Development > Profiling Runs

      • Refresh to Profiling Runs page 5 times.
      • Select to top 3 profiling runs, for each of them
        1. Click the date
        2. Fill in "Mark as reference run/command" with a tick.
        3. Fill in a comment in two of them, but leave the third blank

      Return to; Administration > Site Administration > Development > Profiling Runs

      Click on the profiling script name under URL (admin/tool/profiling/index.php).
      Confirm 3 reference runs are displayed correctly.

      Go back to the profiling list page (Back button).
      Click on the "Date" next to the top profile run for admin/tool/profiling/index.php
      Confirm 3 reference runs are displayed correctly.

      Go back to the profiling list page (Back button).
      Click on the "Date" next to the second bottom profile run for admin/tool/profiling/index.php
      Confirm no reference runs are displayed correctly.

      Open all the reference runs and uncheck them as references.

      Go back to the profiling list page
      Click on the profiling script name under URL (admin/tool/profiling/index.php).
      Confirm no reference runs are displayed.

      Show
      PREREQUSITES: You need the xhprof extension installed. Login as Admin Administration > Site Administration > Development > Profiling Enable Profiling Profile these should be * for all. Save changes Administration > Site Administration > Development > Profiling Runs Refresh to Profiling Runs page 5 times. Select to top 3 profiling runs, for each of them Click the date Fill in "Mark as reference run/command" with a tick. Fill in a comment in two of them, but leave the third blank Return to; Administration > Site Administration > Development > Profiling Runs Click on the profiling script name under URL (admin/tool/profiling/index.php). Confirm 3 reference runs are displayed correctly. Go back to the profiling list page (Back button). Click on the "Date" next to the top profile run for admin/tool/profiling/index.php Confirm 3 reference runs are displayed correctly. Go back to the profiling list page (Back button). Click on the "Date" next to the second bottom profile run for admin/tool/profiling/index.php Confirm no reference runs are displayed correctly. Open all the reference runs and uncheck them as references. Go back to the profiling list page Click on the profiling script name under URL (admin/tool/profiling/index.php). Confirm no reference runs are displayed.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-40793_profile_compare

      Description

      Currently you can only compare a profile with the previous reference run for a single script. This is not always what you need. For example, restore.php has 7 steps that all get profiled under the same script name. It is normal to have baseline profiles for at least 2 of those pages. As a result, you need to be able to quickly pick the relevant reference profile to compare against.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Sep/13