Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      There should be no changes in non-developer modes.

      • Set $CFG->jsrev = -1;
      • Open some pages in Moodle
        • Confirm that all JS works as expected
        • Confirm that there were no JavaScript errors in the console
      • In the console type:

        YUI_config.groups.moodle.modules
        

        • Confirm that a list of modules was shown
      • In config.php, remove the $CFG->jsrev = 1; and add $CFG>cachejs = false;
      • Rinse, wash, repeat.
      Show
      There should be no changes in non-developer modes. Set $CFG->jsrev = -1; Open some pages in Moodle Confirm that all JS works as expected Confirm that there were no JavaScript errors in the console In the console type: YUI_config.groups.moodle.modules Confirm that a list of modules was shown In config.php, remove the $CFG->jsrev = 1; and add $CFG >cachejs = false; Rinse, wash, repeat.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      There are times when it would be really helpful to include module metadata in development mode, just like we do when development is not set.
      This is calculated on each page load so there is an added expense, but it is only when $CFG->jsrev = 1, or $CFG>cachejs = false.

      This will allow us to do more useful things with YUI submodules and break up our JS into more logical blocks.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Sam & Petr, you may have views on this issue.

            Essentially, doing this allows us to have pure meta-modules. So for example we could have moodle-core-util which depends on moodle-core-util-base, moodle-core-util-io, moodle-core-util-banana. For the most part, we can get away with just using -base, but sometimes a developer may want io, and banana too.

            Show
            dobedobedoh Andrew Nicols added a comment - Sam & Petr, you may have views on this issue. Essentially, doing this allows us to have pure meta-modules. So for example we could have moodle-core-util which depends on moodle-core-util-base, moodle-core-util-io, moodle-core-util-banana. For the most part, we can get away with just using -base, but sometimes a developer may want io, and banana too.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Petr - this gets a +1 from me do you have any objections?

            Upgrading this to a blocker (it is blocking other issues right?)

            Show
            samhemelryk Sam Hemelryk added a comment - Petr - this gets a +1 from me do you have any objections? Upgrading this to a blocker (it is blocking other issues right?)
            Hide
            skodak Petr Skoda added a comment -

            +1

            Show
            skodak Petr Skoda added a comment - +1
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Two positive peer reviews. Submitting for Integration.

            Show
            dobedobedoh Andrew Nicols added a comment - Two positive peer reviews. Submitting for Integration.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andrew - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andrew - this has been integrated now
            Hide
            phalacee Jason Fowler added a comment -

            Brilliant work as always Andrew!

            Show
            phalacee Jason Fowler added a comment - Brilliant work as always Andrew!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you!

            "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office."
            Adams, D (1992) Mostly Harmless. London: William Heinemann.

            Show
            samhemelryk Sam Hemelryk added a comment - Against all probability we've achieved normality. You changes didn't break the tests I pretended to run and are now immortalised upstream. Good for you! "It was a programming technique that had been reverse-engineered from the sort of psychotic mental blocks that otherwise perfectly normal people had been observed invariably to develop when elected to high political office." Adams, D (1992) Mostly Harmless. London: William Heinemann.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13