Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-40850

Managefiles plugin does not work consistently when theme is changed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable user themes and course theme, install additional languages
      2. Set custom theme for current user
      3. Set custom theme and/or language for some course
      4. Edit user profile, click "Manage files" button in the textarea, make sure the theme of the popup is the user theme
      5. Make sure the theme/language in the popup is as it is set for the course in each of the following cases:
        1. Editing course settings or section text
        2. Adding a module
        3. Editing a module
        4. Editing contents of HTML block
      6. Make sure the "manage files" button also works when you create course or edit something on frontpage
      Show
      Enable user themes and course theme, install additional languages Set custom theme for current user Set custom theme and/or language for some course Edit user profile, click "Manage files" button in the textarea, make sure the theme of the popup is the user theme Make sure the theme/language in the popup is as it is set for the course in each of the following cases: Editing course settings or section text Adding a module Editing a module Editing contents of HTML block Make sure the "manage files" button also works when you create course or edit something on frontpage
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-40850-master
    • Sprint:
      BACKEND Sprint 7

      Description

      Reported on https://moodle.org/plugins/view.php?plugin=tinymce_managefiles

      Now plugin is in standard package, so it will be fixed both in master version and contributed plugin.

      ------------------

      steve miley
      Wed, Jul 24, 2013, 5:21 AM
      Delete
      Hi - I really like this, and am excited that it may become part of the core in the future. I found at least one bug in 2.5.1+, If you have the clean theme as the default, create a label, add an image in the embedded popup, then save, All seems fine. But if you then edit that label, then click on the tinymce embedded plugin button, you'll get a blank popup.

      if you change your theme to a non-bootstrap theme it works.

      the error we get is -
      Default exception handler: Coding error detected, it must be fixed by a programmer: The course you passed to $PAGE->set_cm does not correspond to the $cm. Debug:
      Error code: codingerror

      • line 952 of /lib/pagelib.php: coding_exception thrown
      • line 3697 of /lib/navigationlib.php: call to moodle_page->set_cm()

      Lastly, there is a quirk, where if I have the default theme set to clean, but the course i'm in set to afterburner, when I click on the embedded tinymce button, i get a popup with the clean theme (not the afterburner theme).

      I could make a video demo of this if it'd be useful.

      THANK YOU FOR your work on this, I really like it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Damyon Wiese
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jan/14